Sewerpipe

[oocube]

Index all items, even those that might get overridden.

[mcarans]

@oocube If I understand correctly, the end output of this is generated HTML. Is that right? If so, is there anywhere I can view the HTML generated by this PR? I tried looking at the output of the builds but they seem to be the Java jar files not the HTML.

[oocube]

There are unit tests that get executed during the maven build. Unless they pass there is no jar file.
But you are right, the html output is generated only when the code executes. I did these tests locally, and they also run as part of https://github.com/OoliteProject/oolite-expansion-catalog (check the referenced website).

If you want to see a sample run I'd have to revive the 'scan' workflow in this project. At least the release step is no longer appropriate.

[oocube]

I added a test run which indexes 20 expansions. The output is available as an additional build artifact. Please take a look.

[mcarans]

I added a test run which indexes 20 expansions. The output is available as an additional build artifact. Please take a look.

The html looks great, but the release here seems to only have the sources: https://github.com/OoliteProject/OoliteAddonScanner/releases. Previous releases had 4 artifacts.

[oocube]

The artifacts are back. Thank you for spotting this.

[mcarans]

Looks good to me!