chore: [SDK-5040] speed up iOS CI workflow and fix flakey tests - #1719
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
fadi-george
force-pushed
the
fadi/sdk-5040
branch
from
August 19, 2026 21:12
3a34764 to
d937a30
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
fadi-george
changed the title
abdulraqeeb33
approved these changes
Aug 20, 2026
nan-li
approved these changes
Aug 20, 2026
nan-li
added a commit
that referenced
this pull request
Aug 21, 2026
These tests were written before #1719 landed, so they grew their own copies of infrastructure that now exists repo-wide: a XCTestCase.waitUntil extension alongside OneSignalCoreMocks.waitUntil, an inlined consistency reset pair alongside ConsistencyManagerTestHelpers.reset, and a private resetOperationRepo alongside OSCoreMocks.resetOperationRepo. Two implementations of the same wait can drift in timeout and semantics, so prefer the shared ones. The flush tests now use OSOperationRepo.flushAndWait, which #1719 added for this: the repo queue is serial and dispatches executors inline, so a sync flush lands every delta and makes the expectation, the timeout and the pre-flush poll unnecessary. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Parallelize iOS CI jobs and reuse a cached KMP XCFramework across simulator and Catalyst checks. Also fixes flakey tests and shrinkes ci time from around ~20 minutes to ~10mins.
Details
Motivation
The iOS CI workflow serially rebuilt and verified the KMP XCFramework before lint, simulator tests, and Catalyst integration checks. The linked baseline took 17m36, including 5m13 for KMP work.
Scope
Splits lint, KMP assembly, simulator tests, and Catalyst integration into separate jobs. The KMP job caches by submodule SHA, runner architecture, and Xcode version, then shares one packaged artifact with both dependent jobs. Simulator build and tests remain together, and release usage retains exhaustive XCFramework verification.
Testing
Unit testing
No SDK runtime behavior changed, so no new unit tests were needed.
Manual testing
Affected code checklist
Checklist
Overview
Testing
Final pass
Made with Cursor