Skip to content

SaiSandeep - Fix "No comparison" filter options failing in Total Org Summary Dashboard #5278

Merged
one-community merged 2 commits into
developmentfrom
saisandeep-fix-filter-options-totalorgsummary
May 25, 2026
Merged

SaiSandeep - Fix "No comparison" filter options failing in Total Org Summary Dashboard #5278
one-community merged 2 commits into
developmentfrom
saisandeep-fix-filter-options-totalorgsummary

Conversation

@saisandeepkoritala
Copy link
Copy Markdown
Contributor

@saisandeepkoritala saisandeepkoritala commented May 16, 2026

Description

When users try to filter stats and compare them by week by week or month by month or year by year by selecting one of the options in dropdown , we get an blank page with error details.
Screenshot 2026-05-14 001530
Screenshot 2026-05-14 001538

Fix

Ensured the data passed onto the children component is rendered properly by handling all edge cases and made sure the code is reusable by extracting some portion of code into a function.

Related PRS :

Not Related to any other PR's

Main changes explained:

Made sure the data is rendered properly in children component

How to test:

  1. check into current branch
  2. do npm install and npm start to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to dashboard→ Reports→ Total Org Summary
  6. Verify all options in "No Comparison" are working properly

Screenshots or videos of changes:

Screenshot 2026-05-16 022543 Screenshot 2026-05-16 022536 Screenshot 2026-05-16 022528

Changes

Screen.Recording_Test.1.mp4

@netlify
Copy link
Copy Markdown

netlify Bot commented May 16, 2026

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 2a27bb1
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6a081dc457edd90008b98f1a
😎 Deploy Preview https://deploy-preview-5278--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

@kunchalasireesha kunchalasireesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2026-05-19.at.7.44.02.PM.mov

LGTM

On clicking the comparison pages, instead of showing the “Something went wrong” message, the pages are reloading properly.

Copy link
Copy Markdown

@DeepighaJ DeepighaJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
Checked out to current branch and tested PR locally.
On navigating to Reports -> Total org summary the below error displays.

Image

@saisandeepkoritala
Copy link
Copy Markdown
Contributor Author

saisandeepkoritala commented May 21, 2026

Hi Checked out to current branch and tested PR locally. On navigating to Reports -> Total org summary the below error displays.

Image

Hi Deepigha thanks for the review. I did check the PR again now and found no issues. I did include a video just in case if something is missing, please do the find the video above under the "changes section" where i included everything from stratch from checking into branch to testing. And let me if you still encountering any issues.

Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I reviewed and tested this PR locally. All options under “No Comparison” in Total Org Summary are working properly as expected.

Image Image Image Image

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit 0a70cf1 into development May 25, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants