Shravan fix conflicts 4351#4954
Open
Shravan-neelamsetty wants to merge 40 commits into
Open
Conversation
…e-dark-mode-total-construction-summary
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
901060b to
6fa3e3b
Compare
|
HemanthNidamanuru
requested changes
Apr 9, 2026
Anusha-Gali
suggested changes
Apr 14, 2026
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Shravan,
I have reviewed your PR locally and in "Total Construction Summary" i found the below issues:
- In Longest Open issues, the chart background when compare to the other charts on the page
- The Supplier Performance dropdown's in Tools and Equipment tracking are not adapted to the same color as other dropdown's.
- The options in the Injury Severity chart in Lessons Learned are not clearly visible when selected
- The options in the Planned vs Actual Cost in Financials are not clearly visible when selected
- The hover text in Global Distribution map is not visible, and a lot of dropdown's and other features are missing when compared to Dev
- The calendar in the Planned vs Actual Cost in Financials is in light mode
The rest of the charts are well adapted to dark mode. The Leaderboard page is also as per requirement.
d7258f1 to
4e075f3
Compare
…ndering across BMDashboard
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


















Description
Resolved all merge conflicts for PR #4351 (Carlos's dark mode implementation for the Total Construction Summary page). This branch merges
carlos-optimize-dark-mode-total-construction-summaryintodevelopmentwith all 16 conflicting files resolved, reviewer feedback addressed, and lint/prettier fixes applied.Fixes merge conflicts blocking PR #4351
Related PRs (if any):
This PR resolves merge conflicts for #4351 by carlos
Main changes explained:
How to test:
shravan-fix-conflicts-4351yarn installandyarn start:localbmdashboard/totalconstructionsummaryScreenshots or videos of changes:
1)issue tracking calender issue solved
2)tools and equipement tracking issue solved
3)lessons learned dark mode issue solved
4)global distribution dark mode issue solved
Note: