Skip to content

[patch] Add support for configuring disk manifests#982

Open
kwame-ansong wants to merge 1 commit intomasterfrom
user/kwame-ansong/add_support_disk_manifests
Open

[patch] Add support for configuring disk manifests#982
kwame-ansong wants to merge 1 commit intomasterfrom
user/kwame-ansong/add_support_disk_manifests

Conversation

@kwame-ansong
Copy link
Copy Markdown
Contributor

@kwame-ansong kwame-ansong commented Apr 1, 2026

Change Description:

  1. Do these changes impact command syntax of any of the packages?
    Yes. This change introduces a new command for configuring disk manifests.

  2. Do these changes impact documentation?
    Yes. This change introduces a new command for configuring disk manifests.

README.md file has been updated.

Validation/testing performed:

All tests passed via `npm run test`

@millerds
Copy link
Copy Markdown
Collaborator

millerds commented Apr 2, 2026

The pipeline is reporting a package-lock.json file that is out of sync with package.json. I'm not sure why that is happening (it's happening with my PR to fix vulnerabilities too), but will need to be corrected before automation will pass in the lab.

@millerds
Copy link
Copy Markdown
Collaborator

millerds commented Apr 2, 2026

So we aren't adding the cli option to 'npm run start' to trigger these settings to be used and instead requiring a separate cli command? I don't have a strong opinion one way or another, I just remember it was mentioned before and wanted to confirm the plan.

@kwame-ansong
Copy link
Copy Markdown
Contributor Author

So we aren't adding the cli option to 'npm run start' to trigger these settings to be used and instead requiring a separate cli command? I don't have a strong opinion one way or another, I just remember it was mentioned before and wanted to confirm the plan.

This PR is the current plan.

@kwame-ansong kwame-ansong reopened this Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants