fix: add input validation for CSV import (#554)#751
Open
AyeshaaRafaqat wants to merge 1 commit intoOWASP:mainfrom
Open
fix: add input validation for CSV import (#554)#751AyeshaaRafaqat wants to merge 1 commit intoOWASP:mainfrom
AyeshaaRafaqat wants to merge 1 commit intoOWASP:mainfrom
Conversation
Author
|
@northdpole would appreciate any feedback on the approach here happy to make changes based on your review. |
Contributor
|
Hi @AyeshaaRafaqat , thanks for working on this! Just a heads up , this issue is also being addressed in PR #682 and PR #683 , which is currently under maintainer review. I hadn’t linked it to the issue earlier while working on it, because it was part of while I was working on MyOpenCRE milestone and was suggested by @northdpole to move my logic into "spreadsheet_parsers.py" with a new function U can refer to this for more information -> #584 (comment) Flagging this here so maintainers are aware of the overlap and can decide the best path forward. Appreciate the effort on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #554
Tested locally by reproducing both cases from the issue.