feat: RN TurboModule -- threading + Fabric integration, rebuilt (supersedes #46) - #72
Open
DjDeveloperr wants to merge 1 commit into
Open
feat: RN TurboModule -- threading + Fabric integration, rebuilt (supersedes #46)#72DjDeveloperr wants to merge 1 commit into
DjDeveloperr wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
DjDeveloperr
added a commit
that referenced
this pull request
Aug 20, 2026
Matches @nativescript/react-native's existing peerDependenciesMeta convention. Without it, npm's auto-peer-install for @nativescript/react-native-screens pulled in react-native-worklets@0.11.4 (peer react-native 0.83-0.86), conflicting with the workspace's real react-native@0.79.5 (pinned transitively via react-native-node-api) and breaking `npm install` at the repo root -- this is what CI's build job runs, and it failed on PR #72 for exactly this reason.
DjDeveloperr
added a commit
that referenced
this pull request
Aug 20, 2026
Matches @nativescript/react-native's existing peerDependenciesMeta convention. Without it, npm's auto-peer-install for @nativescript/react-native-screens pulled in react-native-worklets@0.11.4 (peer react-native 0.83-0.86), conflicting with the workspace's real react-native@0.79.5 (pinned transitively via react-native-node-api) and breaking `npm install` at the repo root -- this is what CI's build job runs, and it failed on PR #72 for exactly this reason.
DjDeveloperr
force-pushed
the
rn-turbomodule
branch
2 times, most recently
from
August 20, 2026 04:43
c2edfcc to
39d1565
Compare
DjDeveloperr
force-pushed
the
rn-turbomodule
branch
from
August 22, 2026 20:05
39d1565 to
e76dea6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
Threading + Fabric integration for the RN TurboModule, rebuilt from scratch after the owner rejected #46's architecture (see DECISIONS.md/ARCHITECTURE.md).
installWorkletRuntimeputs the real NativeScript interop bridge on the worklets UI runtime, so a"worklet"hook calls UIKit directly with zero JSON/RPC round-trip. The UI runtime is main-queue-scheduled but not thread-affine —runOnUISyncis banned, only async crossings allowed — so the UI/JS-thread deadlock is unconstructible rather than merely gated.API shape
One call whose hook names ARE the Fabric ObjC lifecycle names; bodies are worklets:
Proof + line counts
packages/react-native-screens/src/index.tsis a fullUINavigationControllernative stack (push/pop/modal, header config, transitionCoordinator-gated reconciliation) in 458 lines, zero native code — vs. a 16,029-lineNativeScriptScreenStack.tsxfor the same surface in the rejected #46.refactoracross both packages: 44 files, +3,366/-4,553.refactor: 55 files, +4,698/-4,561.What was deleted
The process-wide
UIView/RCTViewComponentViewmethod swizzle (NativeScriptUIView.mm),NativeScriptUIViewManager.mm,NativeScriptUIViewComponentView.{mm,h},NativeScriptUIKitHost.h,installIdleAwareWorkletsFrameLoop,BatchOps.mmand its walkers,nativeCommitObservations/nativeHandleAuthority, the point-fix RPCs, and the olddefineUIKitView/defineUIKitContainer/defineUIViewControllersurface with its registries. Grepped clean — nothing references any of it.Known caveat
UIViewControllerTransitionCoordinator's completion block is declared solely on a protocol; the metadata resolver only walks the concrete class hierarchy, so that one call site needsinterop.Block(fn, "v@?@")instead of a bare closure (seereconcileStackin the screens consumer). Class-declared completions (presentViewController:animated:completion:) already work with a bare closure. #71 fixes this at the runtime level; until it lands, protocol-declared completion params needinterop.Block.Supersedes #46.