feat: full test coverage on macos & ios, v8 14 by DjDeveloperr · Pull Request #28 · NativeScript/napi-ios

DjDeveloperr · 2026-02-24T21:33:16Z

No description provided.

….json

… old runtime tests

- Removed duplicate inclusion of <TargetConditionals.h> in TNSTestNativeCallbacks.h. - Reformatted method calls and assertions in TNSTestNativeCallbacks.m for improved readability. - Updated imports in TestFixtures.h to maintain consistent ordering. - Enhanced RecordTests.js to support both CGRect and NSRect constructors, ensuring compatibility across platforms. - Modified VersionDiffTests.js to handle macOS and iOS version checks more gracefully.

…rce syncing

…acOS test runner

- Introduced ObjCClassMemberOverload structure to manage method overloads. - Updated ObjCClassMember to support multiple overloads and refined member definition logic. - Added jsReadOnlySetter to handle readonly property assignments gracefully. - Enhanced jsCall to resolve method overloads based on argument types. - Implemented URLPattern class in the runtime for URL pattern matching. - Updated metadata generation to include protocol names in category declarations. - Improved duplicate method handling in class member processing.

…ment in macOS

…lity features - Added support for handling C strings as references in TypeConv. - Improved SInt64 and UInt64 type conversions to handle large integers using BigInt. - Enhanced PointerTypeConv to allow for void pointers and improved handling of struct types. - Introduced new utility functions for managing struct encodings and type definitions. - Implemented compatibility shims for UIColor on macOS to ensure consistent behavior. - Updated timer management in Timers.mm to use mutexes for thread safety and prevent memory leaks. - Enabled reference tests in the TestRunner to ensure proper functionality of reference types.

… and type handling - Enhanced memory management in Timers.mm by simplifying deallocation logic. - Improved CFTypeRef handling in TNSReturnsRetained.m to ensure proper memory ownership semantics. - Added metadata generator support for function return ownership tracking with new flags and attributes. - Implemented vector and complex type handling in TypeSpec and MetadataWriter for better type serialization. - Updated test scripts to ensure metadata generator is built before running tests, enhancing build reliability. - Added utility functions for cursor attribute checks in metadata generation.

…bridge

Copilot

Pull request overview

Updates NativeScript’s Apple builds for V8 14 and improved macOS/iOS testing, while cleaning up legacy V8 headers and hardening parts of the ObjC/FFI bridge.

Changes:

Removed legacy v8/include_old inspector + cppgc public headers and metadata files.
Updated ObjC bridge/FFI codepaths (struct/enum handling, function/block wrapping, lifecycle + caching).
Reworked Apple V8 linking to consume libv8_monolith.xcframework and added iOS pointer-compression compile defs.

Reviewed changes

Copilot reviewed 89 out of 1316 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
NativeScript/napi/v8/include_old/inspector/Schema.h	Removed legacy generated inspector protocol header.
NativeScript/napi/v8/include_old/inspector/Runtime.h	Removed legacy generated inspector protocol header.
NativeScript/napi/v8/include_old/inspector/Debugger.h	Removed legacy generated inspector protocol header.
NativeScript/napi/v8/include_old/cppgc/type-traits.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/trace-trait.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/testing.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/source-location.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/sentinel-pointer.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/process-heap-statistics.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/prefinalizer.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/platform.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/persistent.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/object-size-trait.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/name-provider.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/macros.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/liveness-broker.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/internal/pointer-policies.h	Removed legacy cppgc internal header.
NativeScript/napi/v8/include_old/cppgc/internal/persistent-node.h	Removed legacy cppgc internal header.
NativeScript/napi/v8/include_old/cppgc/internal/name-trait.h	Removed legacy cppgc internal header.
NativeScript/napi/v8/include_old/cppgc/internal/member-storage.h	Removed legacy cppgc internal header.
NativeScript/napi/v8/include_old/cppgc/internal/logging.h	Removed legacy cppgc internal header.
NativeScript/napi/v8/include_old/cppgc/internal/gc-info.h	Removed legacy cppgc internal header.
NativeScript/napi/v8/include_old/cppgc/internal/finalizer-trait.h	Removed legacy cppgc internal header.
NativeScript/napi/v8/include_old/cppgc/internal/compiler-specific.h	Removed legacy cppgc internal header.
NativeScript/napi/v8/include_old/cppgc/internal/caged-heap.h	Removed legacy cppgc internal header.
NativeScript/napi/v8/include_old/cppgc/internal/caged-heap-local-data.h	Removed legacy cppgc internal header.
NativeScript/napi/v8/include_old/cppgc/internal/base-page-handle.h	Removed legacy cppgc internal header.
NativeScript/napi/v8/include_old/cppgc/internal/atomic-entry-flag.h	Removed legacy cppgc internal header.
NativeScript/napi/v8/include_old/cppgc/internal/api-constants.h	Removed legacy cppgc internal header.
NativeScript/napi/v8/include_old/cppgc/heap.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/heap-statistics.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/heap-state.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/heap-handle.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/heap-consistency.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/garbage-collected.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/explicit-management.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/ephemeron-pair.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/default-platform.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/custom-space.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/common.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/allocation.h	Removed legacy cppgc public header.
NativeScript/napi/v8/include_old/cppgc/README.md	Removed legacy cppgc documentation.
NativeScript/napi/v8/include_old/cppgc/OWNERS	Removed legacy ownership metadata.
NativeScript/napi/v8/include_old/cppgc/DEPS	Removed legacy include rules metadata.
NativeScript/napi/v8/include_old/OWNERS	Removed legacy ownership metadata.
NativeScript/napi/v8/include_old/DIR_METADATA	Removed legacy directory metadata.
NativeScript/napi/v8/include_old/DEPS	Removed legacy include rules metadata.
NativeScript/napi/v8/include_old/APIDesign.md	Removed legacy V8 API design doc copy.
NativeScript/napi/common/native_api_util.h	Fixed `argc` initialization in callback macro.
NativeScript/libffi/macosx-universal/include/ffitarget.h	Adjusted libffi target config and trampoline sizing logic.
NativeScript/libffi/macosx-universal/include/ffi.h	Modified vendored libffi public header (types/status/layout).
NativeScript/libffi/iphonesimulator-universal/include/ffitarget.h	Adjusted libffi target config and trampoline sizing logic.
NativeScript/libffi/iphonesimulator-universal/include/ffi.h	Modified vendored libffi public header (types/status/layout).
NativeScript/libffi/iphoneos-arm64/include/ffitarget.h	Adjusted libffi target config macros for ARM64.
NativeScript/libffi/iphoneos-arm64/include/ffi.h	Modified vendored libffi public header (types/status/layout).
NativeScript/ffi/node_api_util.h	Removed heap allocation from N-API error-info macro.
NativeScript/ffi/Variable.mm	Added safer metadata string validation and wider symbol lookup.
NativeScript/ffi/Util.mm	Added struct type-encoding discovery and stricter type handling.
NativeScript/ffi/TypeConv.h	Added new conversion flags + `ffiTypeForArgument()` hook.
NativeScript/ffi/Struct.mm	Added struct global aliases, equality helper, and safer instance checks.
NativeScript/ffi/Protocol.mm	Added protocol name fallback resolution logic.
NativeScript/ffi/Object.mm	Added lifecycle association + round-trip reuse improvements.
NativeScript/ffi/Object.h	Exposed lifecycle association helper.
NativeScript/ffi/ObjCBridge.h	Added round-trip cache frames and initialized refs to null.
NativeScript/ffi/JSObject.mm	Fixed bridge-state cleanup ordering on finalize/dealloc.
NativeScript/ffi/Interop.h	Extended Pointer/Reference APIs + FunctionReference signature changes.
NativeScript/ffi/Enum.mm	Added enum global constants, aliasing, and reverse mapping.
NativeScript/ffi/Closure.mm	Added function callback path + NSError out-parameter error mapping.
NativeScript/ffi/Closure.h	Extended Closure ctor and added selector field.
NativeScript/ffi/ClassMember.h	Added overload representation and readonly setter hook.
NativeScript/ffi/ClassBuilder.h	Added multi-descriptor lookup for overload/setter resolution.
NativeScript/ffi/Class.mm	Added pointer-arg interop parsing and “alloc then init(...)” flow.
NativeScript/ffi/Cif.mm	Added CIF construction from runtime `Method` and arg-skipping support.
NativeScript/ffi/Cif.h	Added new CIF constructors (implicit argc + runtime Method).
NativeScript/ffi/CFunction.mm	Adjusted function parsing and return/arg memory ownership flags.
NativeScript/ffi/Block.mm	Added block<->JS callback identity cache and signature helpers.
NativeScript/ffi/Block.h	Exposed block cache/signature helpers + encoding-based wrapper.
NativeScript/CMakeLists.txt	Switched V8 linking to imported xcframework slice + iOS pointer-compression defs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

NativeScript/libffi/macosx-universal/include/ffitarget.h

NativeScript/libffi/macosx-universal/include/ffi.h

Copilot · 2026-02-24T21:47:33Z

NativeScript/ffi/Block.mm

+constexpr int kBlockHasSignature = (1 << 30);
+std::unordered_map<void*, napi_ref> g_blockToJsFunction;


g_blockToJsFunction is a global std::unordered_map accessed from multiple codepaths (block_release, block_finalize, wrapper creation) and can be hit from different threads (blocks can be copied/released off the JS thread). This is a data race and can corrupt the map. Protect all accesses with a mutex (or move the cache behind a single-threaded dispatch queue) and ensure reference deletion happens on the same thread/loop as N-API expects.

Copilot · 2026-02-24T21:47:34Z

NativeScript/CMakeLists.txt

+    if(TARGET_PLATFORM STREQUAL "ios-sim")
+        # Prefer universal sim slice if present
+        set(V8_SLICE_DIR "${V8_XCFRAMEWORK}/ios-arm64-simulator/libv8_monolith.framework")


The xcframework slice selection is hard-coded to *-arm64* paths, which will fail on Intel macOS (macos-x86_64) and Intel iOS Simulator (ios-x86_64-simulator) environments. Select the slice based on CMAKE_OSX_ARCHITECTURES (or CMAKE_SYSTEM_PROCESSOR) and choose the correct xcframework folder (including universal simulator slices if present), otherwise builds will be host-arch dependent.

NativeScript/CMakeLists.txt

NativeScript/ffi/node_api_util.h

NativeScript/ffi/Enum.mm

NativeScript/libffi/macosx-universal/include/ffi.h

DjDeveloperr added 30 commits February 16, 2026 21:50

update metadata & types

e21550b

fix: dont allocate extra error info object

e65eb3e

fix: module resolution allow resolving index.js, dont require package…

1a156a0

….json

fix: proper fail safe jsonparse

aff321d

fix: improved metadata availability checks

3ae4ca9

chore: add scripts to run macos/ios test suite

ec99553

fix: improved URL module compatibility, passes test suite

1af5a9f

feat: addd timeOrigin to performance object

c14b50c

fix: variable getter fallback to RTLD_DEFAULT

0c2de7e

fix: improved module resolution and compatibility functions added for…

d7af30b

… old runtime tests

chore: disable URLPattern tests for now

e1fd13e

fix: refactoring, and compatibility improvements

2b61c33

fix: test runner script paths

7a92860

remove v8 headers

d375034

bump v8 to 14.3.92

c7137d1

fix: build config for latest v8

0a8aca7

fix: add round trip frame guard for objc objects

f89c0e7

more macos tests

505a68b

fixes

7ae91f3

feat: enhance macOS test runner with build state management and resou…

7b4ad3d

…rce syncing

feat: enable additional test modules and enhance crash reporting in m…

cd12261

…acOS test runner

feat: add UTF-8 string coercion utility for URL parsing in macOS

ebc6a1c

feat: Refactor JSObject finalization and enhance NSTimerHandle manage…

ccfe268

…ment in macOS

cleanup autogenerated stuff

e91fa8a

feat: Enhance lifecycle management and improve type handling in ObjC …

cb91a92

…bridge

chore: Remove unused default.profraw file

76b88c5

DjDeveloperr requested a review from Copilot February 24, 2026 21:44

Copilot AI reviewed Feb 24, 2026

View reviewed changes

fix: don’t include v8 headers in repo, include from xcframework

dfb9fcf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

feat: full test coverage on macos & ios, v8 14#28

feat: full test coverage on macos & ios, v8 14#28
DjDeveloperr wants to merge 31 commits intomainfrom
macos-tests

DjDeveloperr commented Feb 24, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		constexpr int kBlockHasSignature = (1 << 30);
		std::unordered_map<void*, napi_ref> g_blockToJsFunction;

Uh oh!

Comments

Conversation

DjDeveloperr commented Feb 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant