Fix args variable in parameter-less custom commands - #1050
Merged
will-lamerton merged 1 commit intoAug 30, 2026
Merged
Conversation
ColumbusLabs
requested review from
Avtrkrb,
akramcodez and
will-lamerton
as code owners
August 29, 2026 17:26
Member
|
Thanks for this PR @ColumbusLabs - feel free to add yourself as a contributor to our website via a PR which I will approve :) https://nanocollective.org/contributors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1035.
Custom commands without declared parameters now receive the aggregate
{{args}}variable, matching commands that do declare parameters. The regression test covers a parameter-less command invoked with multiple arguments.Type of Change
Changeset
pnpm changeset) describing this change for the changelogTesting
Automated Tests
executor.spec.tspnpm run test:all— 6,712 passed, 1 skipped)Manual Testing
Checklist
Additional checks: TypeScript typecheck, Biome formatting/lint, build, Knip, and dependency audit all passed. The repository gate skipped Semgrep because it was unavailable locally.