Skip to content

fix: wrong first argument passed to _refine_depths_with_TSDF - #125

Open
andrewwhitecdw wants to merge 1 commit into
NVlabs:mainfrom
andrewwhitecdw:bugfix/tsdf-optimizer-wrong-first-argument-passed-to-refine
Open

fix: wrong first argument passed to _refine_depths_with_TSDF#125
andrewwhitecdw wants to merge 1 commit into
NVlabs:mainfrom
andrewwhitecdw:bugfix/tsdf-optimizer-wrong-first-argument-passed-to-refine

Conversation

@andrewwhitecdw

Copy link
Copy Markdown

Problem

fix: wrong first argument passed to _refine_depths_with_TSDF

Fix

Replace:

    def _get_depthmaps(self, TSDF_filtering_thresh=None):
        if TSDF_filtering_thresh:
            self._refine_depths_with_TSDF(self.optimizer, TSDF_filtering_thresh)  # compute refined depths if needed
        dms = self.TSDF_im_depthmaps if TSDF_filtering_thresh else self.im_depthmaps
        return [d.exp() for d in dms]

with:

    def _get_depthmaps(self, TSDF_filtering_thresh=None):
        if TSDF_filtering_thresh:
            self._refine_depths_with_TSDF(TSDF_filtering_thresh)  # compute refined depths if needed
        dms = self.TSDF_im_depthmaps if TSDF_filtering_thresh else self.im_depthmaps
        return [d.exp() for d in dms]

Files changed

  • mast3r/cloud_opt/tsdf_optimizer.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant