Skip to content

fix: Per-point LR adjustment is not persisted in optimizer state - #118

Open
andrewwhitecdw wants to merge 1 commit into
NVlabs:mainfrom
andrewwhitecdw:bugfix/per-point-adam-per-point-lr-adjustment-is-not
Open

fix: Per-point LR adjustment is not persisted in optimizer state#118
andrewwhitecdw wants to merge 1 commit into
NVlabs:mainfrom
andrewwhitecdw:bugfix/per-point-adam-per-point-lr-adjustment-is-not

Conversation

@andrewwhitecdw

Copy link
Copy Markdown

Problem

fix: Per-point LR adjustment is not persisted in optimizer state

Fix

Replace:

                    scaled_step_size = step_size * per_point_lr
                    p.data.add_(-scaled_step_size * (exp_avg / denom))
                    per_point_lr = self._adjust_per_point_lr(per_point_lr, grad, mask)

with:

                    scaled_step_size = step_size * per_point_lr
                    p.data.add_(-scaled_step_size * (exp_avg / denom))
                    per_point_lr = self._adjust_per_point_lr(per_point_lr, grad, mask)
                    group['per_point_lr'] = per_point_lr

Files changed

  • scene/per_point_adam.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant