Skip to content

Fix start_scheduler query of __receiver_proxy_base in __task_scheduler.hpp - #2221

Closed
yulin25 wants to merge 3 commits into
NVIDIA:mainfrom
yulin25:receiver-proxy-base-start-sched-query
Closed

Fix start_scheduler query of __receiver_proxy_base in __task_scheduler.hpp#2221
yulin25 wants to merge 3 commits into
NVIDIA:mainfrom
yulin25:receiver-proxy-base-start-sched-query

Conversation

@yulin25

@yulin25 yulin25 commented Aug 21, 2026

Copy link
Copy Markdown

Background

parallel_scheduler causes a compilation error when used in an environment where it is the start scheduler.

What's changed

  • Fall back to inline_scheduler rather than failing compilation if the start scheduler cannot construct a task_scheduler.
  • Fall back to inline_scheduler rather than terminating if constructing the task_scheduler throws.
  • Add a corresponding parallel_scheduler regression test.

When the actual start scheduler cannot be used to construct a task_scheduler,
  fall back to inline_scheduler instead of failing compilation.
When constructing the task_scheduler throws an exception,
  fall back to inline_scheduler instead of terminating.
Parallel scheduler in an environment with itself as the start scheduler.
@copy-pr-bot

copy-pr-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericniebler

Copy link
Copy Markdown
Collaborator

i need to think about this. silently falling back to inline_scheduler is almost never the right thing to do.

@yulin25

yulin25 commented Aug 23, 2026

Copy link
Copy Markdown
Author

Superseded by #2225.

@yulin25 yulin25 closed this Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants