Fix schedule_all chunking for small ranges#2117
Merged
ericniebler merged 1 commit intoJul 5, 2026
Merged
Conversation
ericniebler
approved these changes
Jul 4, 2026
Collaborator
|
/ok to test 4321ae4 |
Contributor
Author
|
@ericniebler Clangformat is failing sadly, let me know if this needs an update from my side. |
Collaborator
|
yes, you need to run clang-format over the two files you changed. |
fallintoplace
force-pushed
the
fix/static-thread-pool-schedule-all-small-ranges
branch
from
e129c17 to
ea73a5d
Compare
Collaborator
|
/ok to test ea73a5d |
Collaborator
|
/ok to test 926e90c |
Collaborator
|
/ok to test bf7b958 |
Collaborator
|
/ok to test 165a98d |
Collaborator
|
@fallintoplace this PR has merge conflicts. can you pls resolve? |
Contributor
Author
|
@ericniebler Sure, let me push this now. |
fallintoplace
force-pushed
the
fix/static-thread-pool-schedule-all-small-ranges
branch
from
165a98d to
b0c28cc
Compare
Collaborator
|
/ok to test b0c28cc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
static_thread_pool::schedule_allbatching so small non-empty ranges always make progress when the pool has more workers than items. The batching code now asserts the existing non-zero worker invariant, clamps non-empty chunk sizes to at least one item, and resets the pending task count after each intermediate flush.Testing
cmake --build build --target test.exec -j 8./build/test/exec/test.exec "schedule_all on static_thread_pool handles ranges smaller than available parallelism"./build/test/exec/test.exec "[types][static_thread_pool]"./build/test/exec/test.exec