fix: remove digit separators from integer literals for clang-scan-deps C++ module compat#2035
Open
guptapratykshh wants to merge 2 commits intoNVIDIA:mainfrom
Open
fix: remove digit separators from integer literals for clang-scan-deps C++ module compat#2035guptapratykshh wants to merge 2 commits intoNVIDIA:mainfrom
guptapratykshh wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
…s C++ module compat Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
ericniebler
requested changes
Apr 19, 2026
clang-scan-deps only parses #if/#else, #include, and import directives, so digit separators in regular C++ code do not affect module scanning. Only the __config.hpp change (in a #if directive) is necessary. Signed-off-by: Pratyksh Gupta <product@revrag.ai>
ericniebler
approved these changes
Apr 19, 2026
Collaborator
|
/ok to test 8d4e20a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang-scan-deps rejects apostrophe-separated digit literals (e.g. 1'000) when scanning dependencies for C++ modules. Remove all digit separators from integer literals in exec and stdexec headers so that dependency scanning succeeds without source patching on the consumer side.