chore(api-db): make the dpa-vni resource pool optional#2035
Merged
Conversation
Any new attempts to run `nico-api` without `[pools.dpa-vni]` set in the site config TOML file will result in `nico-api` crashing with the error: ``` Error: Resource pool 'dpa-vni' missing or full. Edit config file and restart. ``` This should be an optional resource pool since not all sites will need a `"dpa-vni"` resource pool. I think in the past when we managed all NICo sites, we'd prep all site configs with new resource pools, so it wasn't a big deal. Now, however, other teams/orgs/groups run their own NICo stack(s), so it is now up to them whether or not they need to configure this or not. Signed-off-by: Chet Nichols III <chetn@nvidia.com>
bcavnvidia
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Any new attempts to run
nico-apiwithout[pools.dpa-vni]set in the site config TOML file will result innico-apicrashing with the error:This should be an optional resource pool since not all sites will need a
"dpa-vni"resource pool. I think in the past when we managed all NICo sites, we'd prep all site configs with new resource pools, so it wasn't a big deal. Now, however, other teams/orgs/groups run their own NICo stack(s), so it is now up to them whether or not they need to configure this or not.Luckily, we already have
optional_pool_namesfor this!Signed-off-by: Chet Nichols III chetn@nvidia.com
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes