fix: remove transition to CheckingFirmwareRepeatV2 for rms fw updates#2022
Closed
anunna0 wants to merge 2 commits into
Closed
fix: remove transition to CheckingFirmwareRepeatV2 for rms fw updates#2022anunna0 wants to merge 2 commits into
anunna0 wants to merge 2 commits into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
zhaozhongn
approved these changes
May 29, 2026
zhaozhongn
left a comment
zhaozhongn
left a comment
Contributor
There was a problem hiding this comment.
Please wait for one more approval from your team.
Matthias247
reviewed
May 29, 2026
| } | ||
|
|
||
| let next_state = match &rack_fw_status.status { | ||
| model::rack::RackFirmwareUpgradeState::Completed => scenario.actual_new_state( |
Contributor
There was a problem hiding this comment.
does this change the legacy updates in any way? or should they never set that particular status field?
Contributor
Author
There was a problem hiding this comment.
It should only affect rack firmware updates which i believe there is no flow for outside of RMS/SOT
Contributor
There was a problem hiding this comment.
it break Assigned machines
Contributor
|
This wont work for Assigned/Ready. Dont merge this code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After RMS completed the SOT JSON firmware update, BMM was still sending the host into CheckingFirmwareRepeatV2.
That state uses BMM’s old local firmware config, not the SOT JSON. So BMM could decide HGXBmc still needed an update and start a second legacy Redfish firmware update. That second update failed and put the host in FailedFirmwareUpgrade.
Fix: when rack/RMS firmware completes, go straight to the completed host state (Ready) instead of CheckingFirmwareRepeatV2.
Type of Change
Related Issues (Optional)
#2016
Breaking Changes
Testing
Additional Notes