feat(api-model): parse UEFI device paths with 1..N PCI nodes#1977
Open
s3rj1k wants to merge 1 commit into
Open
feat(api-model): parse UEFI device paths with 1..N PCI nodes#1977s3rj1k wants to merge 1 commit into
s3rj1k wants to merge 1 commit into
Conversation
The site-explorer UEFI device-path parser assumed exactly two Pci() nodes, so root-port (PciRoot/Pci) and multi-bridge NIC paths failed to parse. Replace the fixed two-node regex with one accepting any number of PCI nodes, with tests for the new shapes. Signed-off-by: s3rj1k <evasive.gyron@gmail.com>
s3rj1k
force-pushed
the
feat/uefi-multi-pci-parser
branch
from
8b8268b to
b752cc2
Compare
Collaborator
|
/ok to test b752cc2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The site-explorer UEFI device-path parser assumed exactly two Pci() nodes, so root-port (PciRoot/Pci) and multi-bridge NIC paths failed to parse. Replace the fixed two-node regex with one accepting any number of PCI nodes, with tests for the new shapes.
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes