Repository navigation
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
divyegala
force-pushed
the
codex/dedup-raft-keyed-row-reduction
branch
from
October 23, 2026 02:23
9790aa8 to
fe6650a
Compare
divyegala
changed the title
divyegala
changed the base branch from
main
to
codex/dedup-cuda-radix-sorting
October 23, 2026 02:23
divyegala
force-pushed
the
codex/dedup-raft-keyed-row-reduction
branch
from
October 23, 2026 06:33
fe6650a to
c72d00a
Compare
divyegala
changed the base branch from
codex/dedup-cuda-radix-sorting
to
main
October 23, 2026 06:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Share keyed row-reduction dispatch through per-instantiation CUDA launchers and lower kernel owners.
The existing
generate_inst_matrixexpands ordinary JSON matrices directly into separate.cufiles, with one concrete owning instantiation per generated translation unit. Launcher declarations stay in headers; host definitions and the corresponding device kernels stay in CUDA sources. Shared lower kernels have their own owners.Prerequisites:
main.Diff against this PR’s parent: 10 files, +352/−4 lines.
Validation: native JSON/CMake generation checked on this exact branch and its dependency closure; each generated owner has one owning instantiation. Complete-library builds, device-kernel census, and focused runtime checks are tracked in #2888.
Binary savings: the previous figures measured the grouped-owner implementation and are retired for this revised layout. Per-PR CUDA 12.9 and 13.3 complete-library remeasurement is pending; increased fatbin-container overhead means the old figures must not be carried forward.