-
Notifications
You must be signed in to change notification settings - Fork 690
[PyTorch] Fix bug with PR 2677 #2819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sudhakarsingh27
merged 37 commits into
NVIDIA:main
from
sudhakarsingh27:fix_return_stats_max_cudnn
Apr 2, 2026
+32
−7
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
3fb19fc
cudnn now returns Stats always and Max only with `return_max_logit=true`
sudhakarsingh27 5b40701
Merge branch 'main' of github.com:NVIDIA/TransformerEngine
sudhakarsingh27 5d479ad
fix a typo that caused a bug
sudhakarsingh27 296fb9f
update doc strings
sudhakarsingh27 24bfd45
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] fd42feb
fix more docs
sudhakarsingh27 2d7b51b
Merge branch 'fix_return_stats_max_cudnn' of github.com:sudhakarsingh…
sudhakarsingh27 260380b
Merge branch 'main' into fix_return_stats_max_cudnn
sudhakarsingh27 7a5ab35
Merge branch 'main' into fix_return_stats_max_cudnn
sudhakarsingh27 9710810
Merge branch 'main' into fix_return_stats_max_cudnn
sudhakarsingh27 07db752
Merge branch 'main' into fix_return_stats_max_cudnn
sudhakarsingh27 f8b1a68
Merge branch 'main' of github.com:NVIDIA/TransformerEngine into fix_r…
sudhakarsingh27 b5b2b9d
Merge branch 'fix_return_stats_max_cudnn' of github.com:sudhakarsingh…
sudhakarsingh27 8f40cab
fixes from the feedback
sudhakarsingh27 56e46fd
Merge branch 'main' of github.com:NVIDIA/TransformerEngine into fix_r…
sudhakarsingh27 1102738
Merge branch 'main' into fix_return_stats_max_cudnn
sudhakarsingh27 7363541
merge main
sudhakarsingh27 8c0d6a1
Merge branch 'main' of github.com:NVIDIA/TransformerEngine into fix_r…
sudhakarsingh27 d517a13
update cudnn-frontend to v1.19.1
sudhakarsingh27 e005455
Merge branch 'main' of github.com:NVIDIA/TransformerEngine into fix_r…
sudhakarsingh27 3ae0a34
update the cudnn frontend
sudhakarsingh27 ef0d7ec
Merge branch 'main' of github.com:NVIDIA/TransformerEngine into fix_r…
sudhakarsingh27 c7bc0a3
resolve conflicts
sudhakarsingh27 116e24a
Merge branch 'fix_return_stats_max_cudnn' of github.com:sudhakarsingh…
sudhakarsingh27 baa96ff
Merge branch 'main' of github.com:NVIDIA/TransformerEngine into fix_r…
sudhakarsingh27 7122901
fix a wrong omission
sudhakarsingh27 aa9b311
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 799c6d9
Merge branch 'main' of github.com:NVIDIA/TransformerEngine into fix_r…
sudhakarsingh27 599d68f
Merge branch 'fix_return_stats_max_cudnn' of github.com:sudhakarsingh…
sudhakarsingh27 1696f7f
Merge branch 'main' of github.com:NVIDIA/TransformerEngine into fix_r…
sudhakarsingh27 2c52eb3
bugfix: mask out padding tokens when THD
sudhakarsingh27 58b8e82
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 6c6aec4
fixes from greptile feedback
sudhakarsingh27 0deaae2
merge from upstream pull
sudhakarsingh27 757c2de
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] dc7968e
minor nit
sudhakarsingh27 7ef541c
fixes from feedback
sudhakarsingh27 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel the logic (both in ndim=3 branch and ndim=4) is a bit convoluted - it would generate quite a few small kernels. I don't know if there's a more elegant way to program this, or simply zeroing out the entire Max at initialization would be more efficient performance-wise. I'm going to approve for the functionality given that this is also kind of a niche case (THD + return_max_logit=True + pad_between_seqs=True).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have control over
stats/maxtensors? I thought they're passed over by cuDNN.