fix: preserve finding classification during deduplication - #462
Merged
Conversation
rng1995
force-pushed
the
naren/fix-pe3-occurrence-dedup
branch
from
August 31, 2026 15:02
15b29f8 to
5f51f9c
Compare
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
rng1995
force-pushed
the
naren/fix-pe3-occurrence-dedup
branch
from
August 31, 2026 15:06
5f51f9c to
0ea05d3
Compare
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Deduplication grouped findings only by source scope, rule ID, and match fingerprint. Occurrence expansion then copied the selected representative's classification metadata to every grouped location. PE3 findings for a safe read-only
/etc/passwdmount and unsafe access could therefore inherit whichever classification won representative selection.The same incomplete identity was also used earlier in static view deduplication, where it could discard the unsafe finding before report compaction ever saw it. This was order-sensitive and also affected normalized security views.
The fix shares a classification-aware identity across both layers. View-origin tags are ignored only when comparing equivalent projections; meaningful classification and evidence remain distinct. Confidence and location-specific context stay outside the identity, preserving established compaction and highest-confidence selection. Ambiguous evidence never merges and cannot abort terminal/Markdown scans.
Validation
git diff --checkpassed