ci(conformance): add Ubuntu package smoke test - #3127
Draft
SDAChess wants to merge 17 commits into
Draft
Conversation
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
SDAChess
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 2, 2026 12:33
SDAChess
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| runs-on: ${{ inputs.runner }} | ||
| timeout-minutes: 20 | ||
| container: | ||
| image: ghcr.io/nvidia/openshell/ci:latest |
| OPENSHELL_GATEWAY_BINARY="${PWD}/package-binaries/openshell-gateway" \ | ||
| OPENSHELL_DRIVER_VM_BINARY="${PWD}/package-binaries/openshell-driver-vm" \ | ||
| OPENSHELL_DEB_VERSION="${INPUTS_DEB_VERSION}" \ | ||
| OPENSHELL_DEB_ARCH="${{ inputs.arch }}" \ |
elezar
reviewed
Sep 2, 2026
| runs-on: ${{ inputs.runner }} | ||
| timeout-minutes: 20 | ||
| container: | ||
| image: ghcr.io/nvidia/openshell/ci:latest |
Member
There was a problem hiding this comment.
What does this image provide that some standard upstream image does not?
elezar
reviewed
Sep 2, 2026
| - name: Configure package inputs | ||
| run: | | ||
| set -euo pipefail | ||
| chmod +x package-binaries/openshell{,-gateway,-driver-vm} |
Member
There was a problem hiding this comment.
Does this also need to be addressed at the source?
elezar
reviewed
Sep 2, 2026
| path: conformance-input | ||
|
|
||
| - name: Install RPMs and check status | ||
| - name: Run Fedora package conformance |
Member
There was a problem hiding this comment.
nit: Should have been in an earlier commit.
elezar
reviewed
Sep 2, 2026
Comment on lines
+208
to
+209
| env: | ||
| OPENSHELL_TEST_GUEST_DRIVER: podman |
Member
There was a problem hiding this comment.
WHy does this need to be specified here? Should it not be specified in the provisioner?
elezar
reviewed
Sep 2, 2026
| OPENSHELL_TEST_GUEST_CACHE_DISABLE=1 nix run .#test-guest -- \ | ||
| --distro ubuntu-24-04 \ | ||
| --with docker \ | ||
| --install deb-input/*.deb \ |
Member
There was a problem hiding this comment.
This is a bit broader than the rpm pattern.
elezar
reviewed
Sep 2, 2026
| set -euo pipefail | ||
| chmod +x conformance-input/openshell-conformance | ||
| OPENSHELL_TEST_GUEST_CACHE_DISABLE=1 nix run .#test-guest -- \ | ||
| --distro ubuntu-24-04 \ |
Member
There was a problem hiding this comment.
This is different to the rootless config that I have in #3107! That's great!
elezar
reviewed
Sep 2, 2026
Comment on lines
+11
to
+12
| vars: | ||
| openshell_driver: "{{ lookup('ansible.builtin.env', 'OPENSHELL_TEST_GUEST_DRIVER') }}" |
Member
There was a problem hiding this comment.
Should this be set in the container runtime provisioner?
SDAChess
marked this pull request as draft
September 2, 2026 13:30
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an Ubuntu 24.04 conformance target that builds and installs the amd64 Debian package, then runs the shared smoke suite against Docker. Reuse single-target build workflows so conformance consumes the same artifacts as the existing packaging pipelines.
Related Issue
No issue required: this is localized CI coverage and test-harness maintenance.
This change is stacked on the Fedora package conformance work.
Changes
Testing
nix fmt -- --ci nix/test-guest/default.nixbash -n nix/test-guest/run.shnix run .#test-guest -- --listgit diff --checkmise run pre-commit(not run, per request)Checklist