Skip to content

refactor(proto)!: use well-known time types - #3113

Open
derekwaynecarr wants to merge 1 commit into
NVIDIA:mainfrom
derekwaynecarr:refactor/3052-use-well-known-time-types/derekwaynecarr
Open

refactor(proto)!: use well-known time types#3113
derekwaynecarr wants to merge 1 commit into
NVIDIA:mainfrom
derekwaynecarr:refactor/3052-use-well-known-time-types/derekwaynecarr

Conversation

@derekwaynecarr

@derekwaynecarr derekwaynecarr commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

Replace public protobuf timestamp and duration scalars with the standard google.protobuf.Timestamp and google.protobuf.Duration types. This gives API consumers consistent time semantics, preserves sub-second precision, and distinguishes absent optional values from zero-valued times and durations.

Related Issue

Closes #3052

Changes

  • Replaced epoch-millisecond, epoch-string, duration-string, and duration-second protobuf fields with well-known time types while reserving the retired field names and numbers.
  • Added shared Rust helpers for validating and converting protobuf timestamps and durations without losing nanosecond precision.
  • Added transactional startup migration for legacy protobuf payloads stored in SQLite and PostgreSQL, including nested messages and timestamp-valued maps.
  • Updated gateway, CLI, sandbox, compute drivers, middleware, TUI, and provider flows to consume and produce the new fields.
  • Updated the Go, TypeScript, and Python SDK implementations and tests for the new wire representation while preserving their curated public APIs where applicable.
  • Documented the protobuf time conventions, compatibility behavior, and persistence boundary.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture and user-facing documentation are updated

Signed-off-by: Derek Carr <decarr@redhat.com>
@derekwaynecarr
derekwaynecarr requested review from a team, mrunalp and sjenning as code owners September 1, 2026 22:12
@copy-pr-bot

copy-pr-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@derekwaynecarr

Copy link
Copy Markdown
Collaborator Author

/ok to test 62e0845

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(proto)!: use well-known timestamp and duration types

1 participant