fix(server): correct sandbox log bus attribution and lifecycle - #3096
Open
krishicks wants to merge 1 commit into
Open
fix(server): correct sandbox log bus attribution and lifecycle#3096krishicks wants to merge 1 commit into
krishicks wants to merge 1 commit into
Conversation
Five related defects in how gateway log lines are associated with a sandbox and delivered to subscribers. - Treat an empty sandbox id as no sandbox association rather than as a sandbox literally named "". - Make sandbox teardown authoritative for the log bus. Reject late publishers and subscribers, and serialize removal against sender and tail creation so a race cannot resurrect discarded state. - Route ocsf_emit! events into the sandbox log bus; they previously reached the JSONL file but never `openshell logs`. - Emit gateway OCSF events through ocsf_emit! so every emitter uses one path. - Attribute pre-resolution service HTTP failures to their sandbox, which were previously unattributed and so invisible in that sandbox log. Refs #1055 Signed-off-by: Kris Hicks <khicks@nvidia.com>
krishicks
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 1, 2026 16:44
krishicks
enabled auto-merge
September 1, 2026 18:45
krishicks
disabled auto-merge
September 1, 2026 19:24
krishicks
enabled auto-merge
September 1, 2026 19:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix five related defects in how gateway log lines are associated with a sandbox and delivered to subscribers.
Related Issue
Refs #1055
Changes
openshell logs.Testing
mise run pre-commitpassesChecklist