Skip to content

test(e2e): add podman rust suite#1185

Merged
drew merged 1 commit intomainfrom
dn/podman-e2e
May 6, 2026
Merged

test(e2e): add podman rust suite#1185
drew merged 1 commit intomainfrom
dn/podman-e2e

Conversation

@drew
Copy link
Copy Markdown
Collaborator

@drew drew commented May 6, 2026

Summary

Add a Podman-backed Rust e2e entrypoint and make the Rust e2e crate select driver-specific suites with Cargo features instead of runtime skips.

Related Issue

N/A

Changes

  • Add e2e/with-podman-gateway.sh and shared gateway wrapper helpers used by Docker and Podman e2e runs.
  • Make L7 proxy Rust e2e tests use a driver-neutral container helper and GHCR-hosted test server image.
  • Split Rust e2e tests into e2e, e2e-docker, and e2e-docker-gpu Cargo suites.
  • Update Podman driver host aliases and namespace labeling for e2e cleanup and host reachability.
  • Collapse mise run e2e:podman to a single Rust e2e task.

Testing

  • mise run pre-commit passes
  • cargo test --manifest-path e2e/rust/Cargo.toml --features e2e --no-run
  • cargo test --manifest-path e2e/rust/Cargo.toml --features e2e-docker --no-run
  • cargo test --manifest-path e2e/rust/Cargo.toml --features e2e-docker-gpu --no-run
  • Live mise run e2e:podman not run in this session

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (not applicable)

@drew drew added the test:e2e Requires end-to-end coverage label May 6, 2026
@drew drew requested review from a team, derekwaynecarr, maxamillion and mrunalp as code owners May 6, 2026 02:09
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Label test:e2e applied for de6b8d9. Open the existing run and click Re-run all jobs to execute with the label set. The E2E Gate check on this PR will flip green automatically once the run finishes.

@drew drew force-pushed the dn/podman-e2e branch 4 times, most recently from f9c61d1 to 33cb82a Compare May 6, 2026 03:08
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 6, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@drew
Copy link
Copy Markdown
Collaborator Author

drew commented May 6, 2026

/ok to test 33cb82a

@drew drew force-pushed the dn/podman-e2e branch from 33cb82a to 7b7a8c6 Compare May 6, 2026 03:39
@drew
Copy link
Copy Markdown
Collaborator Author

drew commented May 6, 2026

/ok to test 7b7a8c6

@drew drew force-pushed the dn/podman-e2e branch from 7b7a8c6 to f2bd488 Compare May 6, 2026 04:00
@drew
Copy link
Copy Markdown
Collaborator Author

drew commented May 6, 2026

/ok to test f2bd488

@drew drew force-pushed the dn/podman-e2e branch from f2bd488 to e67bd05 Compare May 6, 2026 04:21
@drew
Copy link
Copy Markdown
Collaborator Author

drew commented May 6, 2026

/ok to test e67bd05

@drew drew force-pushed the dn/podman-e2e branch from e67bd05 to fd5e1af Compare May 6, 2026 04:57
@drew
Copy link
Copy Markdown
Collaborator Author

drew commented May 6, 2026

/ok to test fd5e1af

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Comment thread crates/openshell-driver-podman/src/container.rs
Comment thread .github/workflows/e2e-test.yml
Comment thread .github/workflows/e2e-test.yml Outdated
Comment thread .github/workflows/e2e-test.yml
Comment thread e2e/rust/e2e-podman.sh
Comment thread tasks/test.toml
elezar
elezar previously approved these changes May 6, 2026
Copy link
Copy Markdown
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor cleanup / simplification comments, but looks good in general.

@drew
Copy link
Copy Markdown
Collaborator Author

drew commented May 6, 2026

/ok to test b3ed5d9

Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@drew drew force-pushed the dn/podman-e2e branch from b3ed5d9 to 81fa1ed Compare May 6, 2026 18:02
@drew
Copy link
Copy Markdown
Collaborator Author

drew commented May 6, 2026

/ok to test 81fa1ed

@drew drew merged commit 23ad858 into main May 6, 2026
33 of 35 checks passed
@drew drew deleted the dn/podman-e2e branch May 6, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants