Conversation
|
Label |
f9c61d1 to
33cb82a
Compare
Collaborator
Author
|
/ok to test 33cb82a |
Collaborator
Author
|
/ok to test 7b7a8c6 |
Collaborator
Author
|
/ok to test f2bd488 |
Collaborator
Author
|
/ok to test e67bd05 |
Collaborator
Author
|
/ok to test fd5e1af |
|
🌿 Preview your docs: https://nvidia-preview-pr-1185.docs.buildwithfern.com/openshell |
elezar
reviewed
May 6, 2026
elezar
reviewed
May 6, 2026
elezar
reviewed
May 6, 2026
elezar
reviewed
May 6, 2026
elezar
reviewed
May 6, 2026
elezar
reviewed
May 6, 2026
elezar
previously approved these changes
May 6, 2026
Member
elezar
left a comment
There was a problem hiding this comment.
Two minor cleanup / simplification comments, but looks good in general.
Collaborator
Author
|
/ok to test b3ed5d9 |
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Collaborator
Author
|
/ok to test 81fa1ed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a Podman-backed Rust e2e entrypoint and make the Rust e2e crate select driver-specific suites with Cargo features instead of runtime skips.
Related Issue
N/A
Changes
e2e/with-podman-gateway.shand shared gateway wrapper helpers used by Docker and Podman e2e runs.e2e,e2e-docker, ande2e-docker-gpuCargo suites.mise run e2e:podmanto a single Rust e2e task.Testing
mise run pre-commitpassescargo test --manifest-path e2e/rust/Cargo.toml --features e2e --no-runcargo test --manifest-path e2e/rust/Cargo.toml --features e2e-docker --no-runcargo test --manifest-path e2e/rust/Cargo.toml --features e2e-docker-gpu --no-runmise run e2e:podmannot run in this sessionChecklist