Skip to content

feat(installer): support macOS dev installs#1183

Merged
drew merged 3 commits intomainfrom
dn/mac-dev-install
May 6, 2026
Merged

feat(installer): support macOS dev installs#1183
drew merged 3 commits intomainfrom
dn/mac-dev-install

Conversation

@drew
Copy link
Copy Markdown
Collaborator

@drew drew commented May 6, 2026

Summary

Update install-dev.sh so Linux keeps the Debian-package install path, while Apple Silicon macOS installs the generated release Homebrew formula instead of managing tarballs, codesigning, and LaunchAgents directly. The formula remains a release asset for the installer to consume, but the public release notes and quickstart docs no longer advertise it as a user-facing install path.

Related Issue

Not linked.

Changes

  • Added Darwin platform detection for Apple Silicon and a clear Intel macOS unsupported error.
  • Switched the macOS install-dev.sh path to download openshell.rb from the selected release, run brew install/brew reinstall, restart brew services, and register the local gateway.
  • Preserved the Linux Debian-package install path and local gateway registration convention.
  • Generated and uploaded openshell.rb for both tagged releases and the dev release, with fixed SHA-256 values sourced from release checksum files.
  • Included VM driver tarballs in release checksums so the generated formula uses the right openshell-driver-vm-* artifact.
  • Kept Homebrew-specific details in internal VM runtime documentation and removed public Homebrew formula instructions from the README, quickstart, and release body.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (not applicable)

Additional installer and release checks run manually:

  • sh -n install-dev.sh
  • shellcheck install-dev.sh
  • git diff --check
  • uv run pytest python/openshell/release_formula_test.py
  • Fake Homebrew formula generation from checksum files plus ruby -c on generated openshell.rb.
  • Fake Darwin Homebrew install harness confirming formula download, brew install, brew services restart, and local gateway registration.
  • Fake Linux harness confirming Debian asset selection and existing apt/systemd/register flow.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

@drew drew requested review from a team, derekwaynecarr, maxamillion and mrunalp as code owners May 6, 2026 00:09
@drew drew closed this May 6, 2026
@drew drew reopened this May 6, 2026
@drew drew marked this pull request as draft May 6, 2026 04:28
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 6, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@drew drew force-pushed the dn/mac-dev-install branch 2 times, most recently from 60f0716 to 9a8fa2b Compare May 6, 2026 18:02
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

@drew drew marked this pull request as ready for review May 6, 2026 19:52
TaylorMutch
TaylorMutch previously approved these changes May 6, 2026
drew added 3 commits May 6, 2026 13:01
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 6, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@drew drew merged commit 5949b2f into main May 6, 2026
5 checks passed
@drew drew deleted the dn/mac-dev-install branch May 6, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants