WebServiceTarget - Change from legacy HttpWebRequest to HttpClient#19
Open
snakefoot wants to merge 4 commits intoNLog:masterfrom
Open
WebServiceTarget - Change from legacy HttpWebRequest to HttpClient#19snakefoot wants to merge 4 commits intoNLog:masterfrom
snakefoot wants to merge 4 commits intoNLog:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates WebServiceTarget from legacy HttpWebRequest-based sending to HttpClient, and updates the unit test to validate request payload generation via an injectable HttpClient.
Changes:
- Replace async
HttpWebRequestsend/response flow withHttpClient.SendAsyncandHttpRequestMessageconstruction. - Update UTF-8 BOM unit test to capture the last
HttpRequestMessageand payload bytes via a customHttpMessageHandler. - Add
System.Net.Httpreference for .NET Framework builds of the target project.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
tests/NLog.Targets.WebService.Tests/WebServiceTargetTests.cs |
Updates the POST UTF-8 BOM test to validate request body bytes via an injected HttpClient handler. |
src/NLog.Targets.WebService/WebServiceTarget.cs |
Core migration from HttpWebRequest to HttpClient, adds HttpRequestMessage creation and internal client injection for tests. |
src/NLog.Targets.WebService/NLog.Targets.WebService.csproj |
Adds System.Net.Http reference for .NET Framework builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.