DatabaseTargetTests - Add coverage for DbConnectionFactory constructor#67
Open
JohnVerheij wants to merge 1 commit intoNLog:masterfrom
Open
DatabaseTargetTests - Add coverage for DbConnectionFactory constructor#67JohnVerheij wants to merge 1 commit intoNLog:masterfrom
JohnVerheij wants to merge 1 commit intoNLog:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds direct test coverage for the
DatabaseTarget(Func<IDbConnection>)constructor introduced in NLog/NLog#5878. The factory constructor was previously covered indirectly throughDbTypeEnumSetterTest,DbTypeSetterTest, andDbFactoryConnectionStringTest1/2; this brings parity with the existing tests for the legacyDBProviderconstructor.Tests added:
DbConnectionFactoryNullTest- null factory throwsArgumentNullExceptionDbConnectionFactoryReturnsNullTest- factory returning null surfacesNLogRuntimeExceptionDbConnectionFactoryThrowsTest- factory exceptions propagate to the async continuationDbConnectionFactorySimpleWriteTest- end-to-end single writeDbConnectionFactoryBatchedWriteTest- end-to-end batched writeDbConnectionFactoryKeepConnectionTest- persistent-connection modeDbConnectionFactoryWithParametersWriteTest- end-to-end write withAction<IDbDataParameter>parameter setterAll 222 tests pass on net8.0. No production code changes.