Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Cookies policy page to the “questions” Django app and exposes it via a new /cookies route, then links it from the global footer so it’s available across the service for legal documentation compliance.
Changes:
- Add a
/cookiesURL mapped to a newcookies.jinjastatic template. - Add a “Cookies” link to the global footer (alongside Privacy policy).
- Add a Behave feature to check static pages for accessibility violations.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| lung_cancer_screening/questions/urls.py | Adds the cookies route via TemplateView. |
| lung_cancer_screening/questions/jinja2/cookies.jinja | Introduces the Cookies policy content/template. |
| lung_cancer_screening/core/jinja2/layout.jinja | Adds a footer link to the Cookies page. |
| features/static.feature | Adds an accessibility check scenario for static pages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
lung_cancer_screening/core/jinja2/layout.jinja:66
- A new footer navigation item is introduced for the cookies page, but the new feature covers direct navigation only and does not assert that the footer link is present/works when logged out and logged in (which is part of the PR description). Please add an acceptance test that validates the footer contains the "Cookies" link and that it navigates to the cookies page in both states.
{{ footer({
"meta": {
"items": [
{
"href": url("questions:cookies"),
"text": "Cookies"
},
{
"href": url("questions:privacy_policy"),
"text": "Privacy policy"
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Indentation Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Steph Housden <167300771+stephhou@users.noreply.github.com>
|
What is the change?
Why are we making this change?
These changes have been made as a contribution to meeting requirements for legal documentation.