PPHA-542: Improve copy for SmokedAmountForm#319
Closed
Themitchell wants to merge 1 commit intomainfrom
Closed
Conversation
Themitchell
force-pushed
the
PPHA-542-improve-validation-errors
branch
from
ce488ff to
f48846e
Compare
Themitchell
changed the title
|
Contributor
Author
|
closed as fixed in another pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the change?
Improve validation copy and labelling of SmokedAmountForm, handling current / previous smokers, reiterating the smoking frequency in each validation error
Why are we making this change?
To ensure clarity of the question and each possible error