Open
Conversation
Themitchell
force-pushed
the
use-x-forwarded-headers-correctly
branch
from
8383b60 to
3157b2d
Compare
Themitchell
force-pushed
the
use-x-forwarded-headers-correctly
branch
from
3157b2d to
26a00c6
Compare
Use XFORWARDED HOST header correctly and use the default auth enpoint. VTRs can be pased vie extra auth params
Themitchell
force-pushed
the
use-x-forwarded-headers-correctly
branch
from
26a00c6 to
ea03043
Compare
|
|
The review app is available at this URL: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the change?
Use X_FORWARDED_HOST header in production like environments
Why are we making this change?
NHS login redirection happens to the instance url not the users requested domain. This means we no longer have to hardcode the url in auth libraries