Skip to content

VED-1081-Remove-redundant-V2-to-V5-Identifier-Uplift-code#1238

Merged
amarauzoma merged 4 commits intomasterfrom
VED-1081-Remove-redundant-V2-V5-Identifier-Uplift-code
Feb 26, 2026
Merged

VED-1081-Remove-redundant-V2-to-V5-Identifier-Uplift-code#1238
amarauzoma merged 4 commits intomasterfrom
VED-1081-Remove-redundant-V2-V5-Identifier-Uplift-code

Conversation

@amarauzoma
Copy link
Contributor

Summary

We introduced some code to our batch process that manually converts legacy identifiers from V2 to V5 for certain suppliers. This was implemented as a temporary solution because DPS weren't able to do the conversion on their side before we ran the uplift on the data stored in our VEDS DynamoDB table. Therefore, once DPS has completed their uplift, we can consider removing the code.
Note: It might be worth leaving the code in, just in case any legacy identifiers come through. This can be considered / explored as part of this ticket.

Add any other relevant notes or explanations here. Remove this line if you have nothing to add.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

@github-actions
Copy link
Contributor

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-1081

@sonarqubecloud
Copy link

@amarauzoma amarauzoma temporarily deployed to internal-dev-sandbox February 26, 2026 14:26 — with GitHub Actions Inactive
@amarauzoma amarauzoma temporarily deployed to internal-dev-sandbox February 26, 2026 14:26 — with GitHub Actions Inactive
@amarauzoma amarauzoma temporarily deployed to internal-dev-sandbox February 26, 2026 14:27 — with GitHub Actions Inactive
@amarauzoma amarauzoma enabled auto-merge (squash) February 26, 2026 15:34
@amarauzoma amarauzoma merged commit a4bd111 into master Feb 26, 2026
28 of 29 checks passed
@amarauzoma amarauzoma deleted the VED-1081-Remove-redundant-V2-V5-Identifier-Uplift-code branch February 26, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants