VED-1081-Remove-redundant-V2-to-V5-Identifier-Uplift-code#1238
Merged
amarauzoma merged 4 commits intomasterfrom Feb 26, 2026
Merged
VED-1081-Remove-redundant-V2-to-V5-Identifier-Uplift-code#1238amarauzoma merged 4 commits intomasterfrom
amarauzoma merged 4 commits intomasterfrom
Conversation
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-1081 |
JamesW1-NHS
approved these changes
Feb 25, 2026
dlzhry2nhs
approved these changes
Feb 25, 2026
edhall-nhs
approved these changes
Feb 25, 2026
Akol125
approved these changes
Feb 25, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
We introduced some code to our batch process that manually converts legacy identifiers from V2 to V5 for certain suppliers. This was implemented as a temporary solution because DPS weren't able to do the conversion on their side before we ran the uplift on the data stored in our VEDS DynamoDB table. Therefore, once DPS has completed their uplift, we can consider removing the code.
Note: It might be worth leaving the code in, just in case any legacy identifiers come through. This can be considered / explored as part of this ticket.
Add any other relevant notes or explanations here. Remove this line if you have nothing to add.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.