NRL-2015 option 4 - choose v2 if v2 permissions file in lambda layer

[anjalitrace2-nhs]

• use v2 permissions if a v2 permissions file is present in the lambda layer (rather than by if both v1 headers are supplied)

• redid unit tests to match this new behaviour
• all integration tests now include both v1 & v2 headers to best reflect what will be happening in prod going forward. Got rid of v1/v2-specific integration test steps

for even more scenarios see: https://miro.com/app/board/uXjVICmXH9E=/?moveToWidget=3458764664560834826&cot=14

TODO:

• Remove all references to v1 vs v2 in integration tests now that v1 & v2 requests have the same headers
• Write an extra integration test that falls back to v1 when a v2 file isn't present (but a neighbouring ODS is :| )

[github-actions]

💥 Something went wrong while building the pull request environment.
Check Output Logs

[github-actions]

💥 Something went wrong while building the pull request environment.
Check Output Logs

[github-actions]

💥 Something went wrong while building the pull request environment.
Check Output Logs

[github-actions]

🚀 PR environment successfully deployed.
Commit Hash: e49fd0e33858a6868ae428fdd99900ec2538c5c8
URL: https://nrl2015-01ba47.api.record-locator.dev.national.nhs.uk/

[github-actions]

🚀 PR environment successfully deployed.
Commit Hash: b2e301a1f82f4cf287d92eb20c5a8621a5f9da1e
URL: https://nrl2015-01ba47.api.record-locator.dev.national.nhs.uk/

[github-actions]

🚀 PR environment successfully deployed.
Commit Hash: b35b3dbc6fb39380f0c59e9d4a0b20b711a1c25e
URL: https://nrl2015-01ba47.api.record-locator.dev.national.nhs.uk/

[github-actions]

🚀 PR environment successfully deployed.
Commit Hash: 79c6e9fff39dd460580fc6d36b5a1c8adaf05ddc
URL: https://nrl2015-01ba47.api.record-locator.dev.national.nhs.uk/

[mattdean3-nhs]

Looks/works great 💪

Once comment on belt-and-braces error handling but not a blocker for me.

[github-actions]

🚀 PR environment successfully deployed.
Commit Hash: 83e89c9c6b080da3a8362bf070b353eee32e39f6
URL: https://nrl2015-01ba47.api.record-locator.dev.national.nhs.uk/

[github-actions]

🚀 PR environment successfully deployed.
Commit Hash: 680c5b067a9d38c3299d6c373bcb7dad932db986
URL: https://nrl2015-01ba47.api.record-locator.dev.national.nhs.uk/

[github-actions]

🚀 PR environment successfully deployed.
Commit Hash: 6bed05082e702eb1a1355b1fe6d7a0869a2bcc07
URL: https://nrl2015-01ba47.api.record-locator.dev.national.nhs.uk/

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

🚀 PR environment successfully deployed.
Commit Hash: 644137f7dd98fffe6f26da063364f6cd459e6adc
URL: https://nrl2015-01ba47.api.record-locator.dev.national.nhs.uk/