Repository navigation
Ascent Guidance reorganised (type first, one Launch choice, three window buttons); PSG Settings merged into Ascent Settings and PSG Stages - #2768
Merged
Conversation
…solver's numbers in a saved fold The window read bottom-up: Engage at the top, the ascent type in a drop-down at the bottom although it decides every row, the launch buttons and the countdown at the end, and PSG's solver numbers in the middle before anything ran. Now, top to bottom: - Classic | PSG, locked (dimmed, with a tooltip saying why) while engaged. - TARGET: the orbit, as before. "Ap < Pe: circularizing orbit" is a dim note, as a circular orbit is the default, not a warning. - LAUNCH, on the ground: one Launch choice (Now, Into the target's plane, and for PSG To the target's LAN and To a LAN) with the LAN offset or LAN it needs, "Launch at once, without waiting for the plane" for the timed ones, and the Countdown, always shown (it was hidden unless Auto-warp was on, and PSG also starts guidance with it). Engage starts the chosen launch's countdown and engages (MechJebModuleAscentMenu.Engage); a target launch without a target disables Engage and says why. While counting down: the timer and Abort. - Engage / Disengage, then the autopilot and guidance status bars and the last failure. - The ascent's windows as buttons: Settings, PSG Settings, Stages and Solution for PSG; Settings and Path for Classic. - GUIDANCE DETAILS (PSG): vgo, tgo, heading, pitch, converges, staleness, n, infeasibility, folded by default, the fold's state saved (GuidanceDetailsOpen). The launch choice is saved too (LaunchChoice).
…or after a failure, not on the pad
…nce opens three windows As the UX review's mockups have it, PSG Settings goes, and its rows go to the window whose job they share: - Ascent Settings, under PSG: the Qα limit (PSG's angle-of-attack limit, beside Classic's Limit AoA, with its clamped/recommended status bar) and the pitch-over (Booster Pitch start and rate) under STEERING; a DRAG MODEL group with Cd and Aref (and the "Aref is 0" note); Draw Trajectory on Map under OTHER. - PSG Stages, under the table, PLAN OPTIONS: Min ΔV (it decides which rows exist), Min Coast and Max Coast, Ullage lead time (the coast row's ullage), ω (the Spin column's rate), and the coast's no-relight note. - Gone: the read-only stage list and the "under Min ΔV" note (the table shows both), the Stage editor and Reset plan buttons (the table has them), and Spinup lead time, which no flight code reads (the setting stays for kOS). Ascent Guidance's buttons are Settings, Stages and Solution for PSG. The PSG warnings badge the button of the window that holds their setting: Aref and Qα on Settings, the coast times and no-relight on Stages. MechJebModuleAscentPSGSettingsMenu and its view are removed; _lastPSGSettingsEnabled stays as a plain field because the kOS bindings set it.
… share the whole row
… in Ascent Settings' DRAG MODEL group Dev's PSG Settings window got the "Cd and Aref from the vessel" switch and its read-only Cd and Aref (#2742, #2748, #2750). This branch merges that window into Ascent Settings, so those rows go to its DRAG MODEL group, and the estimate updates while the ascent type is PSG.
…dow was made under Classic PropertyGrid.Value takes a template to size the value's cell; without one the cell is sized from the value when the row is made, which is empty before the first estimate.
# Conflicts: # Localization/en-us.cfg # Localization/zh-cn.cfg
Contributor
✅ Build Artifact 🚀MechJeb2-3c0f6ba.zip (built from e35ed13) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first step of the ascent menu reorganisation. Ascent Guidance read bottom-up: Engage at the top, the ascent type in a drop-down at the bottom although it decides every row, the launch buttons and the countdown at the end, and PSG's solver numbers in the middle before anything ran. PSG Settings was a third window to know about.
Ascent Guidance, top to bottom
MechJebModuleAscentMenu.Engage).PSG Settings merged into Ascent Settings and PSG Stages
MechJebModuleAscentPSGSettingsMenuand its view are removed._lastPSGSettingsEnabledstays as a plain field because the kOS bindings set it.The launch choice and the fold's state are saved (
LaunchChoice,GuidanceDetailsOpen, global).Tested in game: 17 pass, 0 fail. PC, Debug, development player, Kerbal XI on the MJTesting pad, nothing flown. It checks: