Skip to content

Ascent Guidance reorganised (type first, one Launch choice, three window buttons); PSG Settings merged into Ascent Settings and PSG Stages - #2768

Merged
sarbian merged 8 commits into
devfrom
ui/ascent-guidance-layout
Nov 16, 2026
Merged

sarbian merged 8 commits into
devfrom
ui/ascent-guidance-layout

Conversation

@sarbian

@sarbian sarbian commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

The first step of the ascent menu reorganisation. Ascent Guidance read bottom-up: Engage at the top, the ascent type in a drop-down at the bottom although it decides every row, the launch buttons and the countdown at the end, and PSG's solver numbers in the middle before anything ran. PSG Settings was a third window to know about.

Ascent Guidance, top to bottom

  • Classic | PSG: locked (dimmed, with a tooltip saying why) while the ascent is engaged.
  • TARGET: the orbit, as before. "Ap < Pe: circularizing orbit" is a dim note: a circular orbit is the default, not a warning.
  • LAUNCH, on the ground:
    • One Launch choice: Now and Into the target's plane, plus To the target's LAN and To a LAN for PSG. It shows the LAN offset or LAN that choice needs.
    • Engage starts the chosen launch's countdown and engages in one press (MechJebModuleAscentMenu.Engage).
    • A target launch without a target disables Engage, and the window says why.
    • For the timed choices, "Launch at once, without waiting for the plane" (the old "Override Warp to Plane"). It still aims at the target's plane, so it is not the same as Now.
    • Countdown, always shown. It was hidden unless Auto-warp was on, and PSG also starts guidance with it.
    • While counting down: the timer and Abort.
  • Engage / Disengage, then the autopilot status. The guidance status bar shows only while the ascent flies or after a failure.
  • Buttons sharing one row: Settings, Stages and Solution for PSG; Settings and Path for Classic.
  • GUIDANCE DETAILS (PSG): the solver's numbers, folded by default.

PSG Settings merged into Ascent Settings and PSG Stages

  • Ascent Settings, under PSG:
    • STEERING gets the Qα limit (PSG's angle-of-attack limit, beside Classic's Limit AoA, with its clamped/recommended bar) and Booster Pitch start and rate.
    • A DRAG MODEL group holds "Cd and Aref from the vessel" with Cd and Aref (typed in, or read-only when estimated), and the "Aref is 0" note.
    • OTHER gets Draw Trajectory on Map.
    • None of these show under Classic.
  • PSG Stages, under the table: PLAN OPTIONS with Min ΔV, Min Coast, Max Coast, Ullage lead time, ω, and the coast's no-relight note.
  • Dropped:
    • "Spinup lead time": no flight code reads it. The setting stays for kOS.
    • The read-only stage list and the "under Min ΔV" note: the table shows both.
  • Warning badges: the Aref and Qα warnings mark Settings; the coast warnings mark Stages.
  • MechJebModuleAscentPSGSettingsMenu and its view are removed. _lastPSGSettingsEnabled stays as a plain field because the kOS bindings set it.

The launch choice and the fold's state are saved (LaunchChoice, GuidanceDetailsOpen, global).

Tested in game: 17 pass, 0 fail. PC, Debug, development player, Kerbal XI on the MJTesting pad, nothing flown. It checks:

  • The row order and the three buttons.
  • The PSG rows in Ascent Settings under PSG, and none of them under Classic.
  • PSG Stages' plan options, with no Spinup lead time.
  • The fold, which opens again from the saved state after a rebuild.
  • Engage disabled with the reason shown for a target launch without a target.
  • The LAN offset with a target, and the LAN field for To a LAN.
  • Engage starting the launch into the target's plane, the type locked, and Abort ending it.
  • The guidance status bar hidden on the pad and shown while engaged.
  • No errors logged.

…solver's numbers in a saved fold

The window read bottom-up: Engage at the top, the ascent type in a drop-down
at the bottom although it decides every row, the launch buttons and the
countdown at the end, and PSG's solver numbers in the middle before anything
ran. Now, top to bottom:
- Classic | PSG, locked (dimmed, with a tooltip saying why) while engaged.
- TARGET: the orbit, as before. "Ap < Pe: circularizing orbit" is a dim note,
  as a circular orbit is the default, not a warning.
- LAUNCH, on the ground: one Launch choice (Now, Into the target's plane, and
  for PSG To the target's LAN and To a LAN) with the LAN offset or LAN it
  needs, "Launch at once, without waiting for the plane" for the timed ones,
  and the Countdown, always shown (it was hidden unless Auto-warp was on, and
  PSG also starts guidance with it). Engage starts the chosen launch's
  countdown and engages (MechJebModuleAscentMenu.Engage); a target launch
  without a target disables Engage and says why. While counting down: the
  timer and Abort.
- Engage / Disengage, then the autopilot and guidance status bars and the
  last failure.
- The ascent's windows as buttons: Settings, PSG Settings, Stages and
  Solution for PSG; Settings and Path for Classic.
- GUIDANCE DETAILS (PSG): vgo, tgo, heading, pitch, converges, staleness, n,
  infeasibility, folded by default, the fold's state saved
  (GuidanceDetailsOpen).
The launch choice is saved too (LaunchChoice).
…nce opens three windows

As the UX review's mockups have it, PSG Settings goes, and its rows go to the
window whose job they share:
- Ascent Settings, under PSG: the Qα limit (PSG's angle-of-attack limit,
  beside Classic's Limit AoA, with its clamped/recommended status bar) and the
  pitch-over (Booster Pitch start and rate) under STEERING; a DRAG MODEL group
  with Cd and Aref (and the "Aref is 0" note); Draw Trajectory on Map under
  OTHER.
- PSG Stages, under the table, PLAN OPTIONS: Min ΔV (it decides which rows
  exist), Min Coast and Max Coast, Ullage lead time (the coast row's ullage),
  ω (the Spin column's rate), and the coast's no-relight note.
- Gone: the read-only stage list and the "under Min ΔV" note (the table shows
  both), the Stage editor and Reset plan buttons (the table has them), and
  Spinup lead time, which no flight code reads (the setting stays for kOS).

Ascent Guidance's buttons are Settings, Stages and Solution for PSG. The PSG
warnings badge the button of the window that holds their setting: Aref and Qα
on Settings, the coast times and no-relight on Stages.
MechJebModuleAscentPSGSettingsMenu and its view are removed;
_lastPSGSettingsEnabled stays as a plain field because the kOS bindings set it.
… in Ascent Settings' DRAG MODEL group

Dev's PSG Settings window got the "Cd and Aref from the vessel" switch and its read-only Cd and Aref (#2742, #2748, #2750). This branch merges that window into Ascent Settings, so those rows go to its DRAG MODEL group, and the estimate updates while the ascent type is PSG.
…dow was made under Classic

PropertyGrid.Value takes a template to size the value's cell; without one the cell is sized from the value when the row is made, which is empty before the first estimate.
# Conflicts:
#	Localization/en-us.cfg
#	Localization/zh-cn.cfg
@sarbian
sarbian merged commit 8cdbc84 into dev Nov 16, 2026
@sarbian
sarbian deleted the ui/ascent-guidance-layout branch November 16, 2026 23:21
@github-actions

Copy link
Copy Markdown
Contributor

✅ Build Artifact 🚀

MechJeb2-3c0f6ba.zip (built from e35ed13)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant