feat(admin): expose BondResolution payload on adm-settle / adm-cancel#167
Conversation
Add --slash-seller and --slash-buyer flags to the AdmSettle and AdmCancel subcommands so QA / solvers can exercise the anti-abuse-bond Phase 2 flow shipped in MostroP2P/mostro#737. When either flag is set, the dispute message now carries a Payload::BondResolution; with no flags the payload stays None to preserve Phase 1 behaviour. The slash decisions are also surfaced in the printed action table. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughThis PR extends the admin dispute cancel and settle commands with optional bond slashing flags. Two new boolean CLI arguments ( ChangesAdmin Dispute Bond Resolution
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Adds
--slash-sellerand--slash-buyerflags to theadm-settleandadm-canceladmin subcommands so solvers (and QA) can exercise the anti-abuse-bond Phase 2 flow shipped in the daemon. When either flag is set, the outgoing dispute message now carriesPayload::BondResolution { slash_seller, slash_buyer }; with no flags, the payload staysNone, preserving Phase 1 behaviour. The selected slash decisions are surfaced as extra rows in the action table so the operator can see what they're about to send.Spec / context: MostroP2P/mostro#737 (
feat/bond-phase-2-slash, daemon §7.2 wire format).Test plan
cargo fmt --allcargo clippy --all-targets --all-features -- -D warningscargo buildcargo test(no regressions; no admin-command tests existed and none added)>= 0.17.3):mostro-cli admsettle --orderid <uuid>→ payloadnullmostro-cli admsettle --orderid <uuid> --slashbuyer→{ slash_seller: false, slash_buyer: true }mostro-cli admsettle --orderid <uuid> --slashseller --slashbuyer→ both truemostro-cli admcancel --orderid <uuid> --slashseller→{ slash_seller: true, slash_buyer: false }bondstable /mostrodlogs.🤖 Generated with Claude Code
Summary by CodeRabbit
--slash-sellerand--slash-buyerboolean flags to admin settle and cancel dispute commands. These flags enable fine-grained control over bond resolution during dispute closure operations.