fix(fs): list files inside untracked directories in git status#2060
fix(fs): list files inside untracked directories in git status#2060chengluyu wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 499d031 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61260fd92f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
61260fd to
fccbaa1
Compare
git status --porcelain defaults to untracked-files=normal, which collapses untracked directories to their directory entry — a new file inside an untracked dir (e.g. docs/new.md) never surfaced in the Changes panel. Pass --untracked-files=all so entries are reported per file.
fccbaa1 to
499d031
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 499d031fe9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| * the local disk; status passes `--untracked-files=all` so files inside | ||
| * untracked directories surface individually instead of collapsing into the | ||
| * directory entry. Process spawning goes through the App-scope |
There was a problem hiding this comment.
This new header clause documents the exact git status flag used rather than the module's external role/responsibility, so it violates the v2 comment convention and can drift the next time status spawning changes. Please keep the observable behavior covered by the test/code and avoid naming the implementation flag in the module header.
AGENTS.md reference: packages/agent-core-v2/AGENTS.md:L13-L13
Useful? React with 👍 / 👎.
1 participant
Problem
git status --porcelain=v1defaults tountracked-files=normal, which collapses untracked directories to a single?? dir/entry. A new file inside an untracked directory (e.g.docs/new.md) never surfaces in the Changes panel — only the collapsed directory row appears, and the actual file is invisible.Fix
Pass
--untracked-files=allto the status command inGitService.statusso entries are reported per file. Ignored paths (node_modules, build output) are unaffected — gitignore still applies.Tests
lists files inside untracked directories individually(fails without the flag: entries collapse tonewdir/).@moonshot-ai/agent-core-v2: 258 files / 3917 tests pass, typecheck + domain lint OK.Changeset: patch (
@moonshot-ai/agent-core-v2).