-
Notifications
You must be signed in to change notification settings - Fork 757
feat(agent-core): thread roleAdditional through the session API #2033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TennyZhuang
wants to merge
2
commits into
MoonshotAI:main
Choose a base branch
from
TennyZhuang:port-roleadditional-behavior
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@moonshot-ai/agent-core": minor | ||
| "@moonshot-ai/kimi-code-sdk": minor | ||
| --- | ||
|
|
||
| Add a `roleAdditional` option to the session API. The agent profile system already renders a `{{ROLE_ADDITIONAL}}` slot, but there was no way to set it through the SDK — the render half existed with no input path. `createSession` / `resumeSession` now accept an optional `roleAdditional` string that is threaded (parallel to `additionalDirs`) into the resolved profile's system prompt for every agent in the session. When resume or reload supplies a `roleAdditional` that differs from the value that rendered an agent's persisted prompt, that agent's system prompt is re-rendered from the restored profile; an omitted value preserves the persisted standing prompt (so `Session.reloadSession()` / `/reload`, which cannot pass one, no longer clears it), while an explicit empty string clears it. Additive and optional — no behavior change when unset. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a session that was created or resumed with
roleAdditionalis later reloaded, the reload path callsresumeSessionWithOverrides({ sessionId })without a way to pass the previous value, sothis.roleAdditionalisundefinedhere whilemeta.roleAdditionalstill contains the original text. This comparison then refreshes the system prompt with the{{ROLE_ADDITIONAL}}slot cleared and recordsundefined, silently dropping the standing prompt on SDKSession.reloadSession()//reload; either thread the value through reload or treat an omitted value as preserving the persisted prompt.Useful? React with 👍 / 👎.