Port the ES8311 audio-reactive board definition to the Waveshare ESP3…

[TouchMyLight]

…2-P4-ETH

Writes the hardware reference page for the Waveshare ESP32-P4-ETH's onboard ES8311 codec and Ethernet wiring, which PR #128's firmware-variant approach never landed on main after PR #129 made the codec runtime configuration. Also renames the shared P4 Ethernet preset to "P4-NANO/ETH" so its UI label doesn't imply it's NANO-only.

Core

• EthernetModule.h: kEthPresets' shared P4 RMII row renamed "P4-NANO" → "P4-NANO/ETH", naming both boards that use it; doc comment updated to match.

Scripts/MoonDeck

• check_devices.py: its own restatement of the preset label (cross-checked against platform_config.h's chip default) updated to match the rename — this is the check that caught the miss on the first pass.

Docs/CI

• New docs/reference/hardware/esp32-p4-eth.md: audio (ES8311) and Ethernet pin tables, free-GPIO table, bench-verification notes, written against the current runtime-codec architecture (AudioService/I2cBusModule), not copied from the closed PR Add ES8311 audio-reactive support for the Waveshare ESP32-P4-ETH #128.
• firmware-variants.md, gpio-usage.md: P4-ETH named alongside the P4-NANO as sharing esp32p4rev1-eth.
• mkdocs.yml: nav entry for the new page.
• mooninstaller/deviceModels.json: the renamed preset label carried into all 5 P4-family catalog entries that reference it.

Bench-verified on the Waveshare ESP32-P4-ETH (plain esp32p4rev1-eth firmware, no new variant): I2C bus scan ACKs the codec at 0x18, AudioService reports live mic data, Ethernet link + DHCP hold, and the renamed preset round-trips cleanly on an already-provisioned board (auto-resolves to the new label, same pins, no reseed to Custom).

Reviews

• Pre-existing, unrelated to this diff (confirmed by reproducing on a clean main): check_docgen carries 1 pre-existing error (Hub75Slots.h) and check_code a 4-finding drift, both from commits already on main before this branch started — named here rather than fixed, since neither file is touched by this change.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Repository: MoonModules/MoonLight/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 58f3884b-7ebc-4f71-9e43-ecd8ff49a6c3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[TouchMyLight]

note: the ESP32-P4-ETH definition is important for an upcoming PR using this board: a MountSd service to use the microSD slot on this board

[ewowi]

Thanks for this, and for testing it on the real board end to end (codec ACK at 0x18, live mic data, Ethernet link): that is exactly the verification we want for a new board.

A few changes before we merge:

1. Drop the preset rename (3 files). We are renaming the shared presets by their wiring rather than by the boards that use them, so the label does not grow with every board on the same pinout. P4-NANO becomes P4 RMII and S31 CoreBoard becomes S31 RGMII, beside Classic RMII. That lands in our next PR, together with its MIGRATING entry. Please revert your changes to src/core/system/EthernetModule.h, moondeck/check/check_devices.py and mooninstaller/deviceModels.json, so the PR leaves those files as they are on main. The Waveshare ESP32-P4-ETH catalog entry is already on main from #129.

2. Name the preset P4 RMII on the page. That is the line Catalog entry: EthernetModule.ethBoard = "P4-NANO/ETH".

3. Keep the page to what only it knows. Every fact has one home in this repo, and a page links to it rather than repeating it:

• The Ethernet pin table repeats the P4 RMII preset row in EthernetModule.h. One sentence saying the board uses P4 RMII, plus the link, covers it.
• The audio pins and codec settings are the catalog entry's. Saying the entry configures the ES8311 and linking AudioService and I2cBus is enough.
• The free-GPIO section repeats gpio-usage.md's P4 set. Your new row there already covers the board, so the section, and the extra sentence after the NANO's clear set, can go.

What stays is what nobody else records: the pins read from the schematic, the speaker path not being supported (DSDIN 9, PA_Ctrl 53), and the other onboard features.

4. Documentation style (documentation-standards.md):

• No em-dashes; the page has 7. A colon, a comma or a new sentence works in each place.
• Present tense, describing what is, with no process history. "Bench-verified 2026-10-06", "the flattened PDF text extraction was ambiguous here; confirmed by eye" and "carried over from the P4-NANO preset" belong in the PR description, which already has them.
• datasheet/ESP32-P4-ETH/ESP32-P4-ETH-datasheet.pdf is not in the repo. Link the Waveshare wiki or schematic URL instead.

uv run moondeck/check/check_prose.py and uv run moondeck/docs/build_docs.py --strict catch most of point 4 locally.

5. Merge order. Once points 1 to 4 are done, this PR and ours touch no common lines, so either can merge first.

firmware-variants.md, the gpio-usage.md row and the nav entry are good as they are. Thanks again for adding the board.

[TouchMyLight]

Good point using the generic P4 RMII name. I made the corresponding changes and completed the GPIO usage.

[ewowi]

Merged the PR, thx! due to this we have a better name for the P4 ethernet preset and the better default pins for the p4-eth.

And this is the first PR merged by somebody else than me , congratulations;-)

(I still have some things in my head to better explain how contributions work , as some things are quite complex and with a lot of rules. So any feedback you have is welcome as well