You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
rfc: composable GQ without a language break - #1244
Proposes an additive alternative to #1202 and #1213: scalar bindings, nested read relations, and file-local named-read reuse within the existing GQ query structure. Existing queries retain their syntax, effects, result contracts, and ranking behavior.
The retrieval design distinguishes filtering a fixed candidate window from selecting the best qualifying results across the full eligible population. An uncapped squared_l2 scorer composes with ordinary filtering, ordering, and a final limit. The RFC specifies numerical/null behavior, exact stopping, explicit cut boundaries, shared resource limits, and scoped ranking metadata. Its acceptance fixture returns ten qualifying documents where filtering an exact nearest-100 window returns none.
Includes compatibility gates, test ownership, staged rollout, and source inspection against the current Lance 13 / DataFusion 54 base. Registers the RFC as a draft; this PR implements no language or runtime changes and claims no executable syntax or performance proof.
Independent design review of retrieval semantics and compatibility with current main completed; numerical failure preservation and root ranking metadata incorporated.
No Rust tests were run because this is a design-document-only change. New syntax and implementation acceptance tests remain explicit RFC gates.
Thank you for this. The maintainer accepted compositional closure on 2026-11-03, and the single GQ 3 RFC, #1302, now carries it: three value kinds, one binder (let), relation expressions drawn with from, and a composed core. Where this draft and the RFC differ, the RFC's Alternatives table names the row: let … in and positional tuples against from with columns by name; squared_l2 beside nearest against l2 and nearest as two operators for two contracts; no reserved forms and no break against one break of seven machine-applied spellings. Your 100-and-11 fixture is in the before-and-after corpus, and the root-versus-producer ranking metadata and the numerical contract are taken. Leaving this open for your reply; it can close once you have read the RFC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposes an additive alternative to #1202 and #1213: scalar bindings, nested read relations, and file-local named-read reuse within the existing GQ query structure. Existing queries retain their syntax, effects, result contracts, and ranking behavior.
The retrieval design distinguishes filtering a fixed candidate window from selecting the best qualifying results across the full eligible population. An uncapped
squared_l2scorer composes with ordinary filtering, ordering, and a final limit. The RFC specifies numerical/null behavior, exact stopping, explicit cut boundaries, shared resource limits, and scoped ranking metadata. Its acceptance fixture returns ten qualifying documents where filtering an exact nearest-100 window returns none.Includes compatibility gates, test ownership, staged rollout, and source inspection against the current Lance 13 / DataFusion 54 base. Registers the RFC as a draft; this PR implements no language or runtime changes and claims no executable syntax or performance proof.
Validation:
No Rust tests were run because this is a design-document-only change. New syntax and implementation acceptance tests remain explicit RFC gates.