Skip to content

26.1#135

Draft
reoseah wants to merge 13 commits intoModFest:26.1from
reoseah:26.1
Draft

26.1#135
reoseah wants to merge 13 commits intoModFest:26.1from
reoseah:26.1

Conversation

@reoseah
Copy link

@reoseah reoseah commented Feb 21, 2026

No description provided.

@reoseah
Copy link
Author

reoseah commented Feb 21, 2026

Maybe it would be better if the first three commits (./gradlew migrateMappings to official and manual fixes to mixins and access wideners, tested by running and placing most of the blocks in game successfully) are merged separately, because together this is going to be way too large commit to review

@reoseah
Copy link
Author

reoseah commented Feb 21, 2026

Good news - it runs. Bad news - nothing renders lmao
2026-02-21_22 27 39
2026-02-21_22 27 47

@reoseah
Copy link
Author

reoseah commented Feb 21, 2026

Even better news, I was just using transparent white (0x00FFFFFF) instead of opaque one (0xFFFFFFFF)
2026-02-21_22 32 13

@Awakened-Redstone Awakened-Redstone changed the base branch from 1.21.7 to 26.1 March 18, 2026 14:43
@Awakened-Redstone Awakened-Redstone self-requested a review March 18, 2026 16:14
@Awakened-Redstone Awakened-Redstone self-assigned this Mar 18, 2026
@Awakened-Redstone
Copy link

If GuiRendererMixin managed to still be working since 1.21.7 I will be surprised.

Also, I'll start looking into the PR soon and see if I can merge it, or at least some of it's changes to the 26.1 branch to start working on it.

@reoseah
Copy link
Author

reoseah commented Mar 20, 2026

This was in Discord server, just summarizing here:

  • it used an old version of Loom that doesn't remap mixins, and I didn't know that and updated mixins manually, so there might be some mistakes? I think the item that renders in hand a la map is broken, I would copy project before remapping, bump Loom version, remap to mojmap, and check "properly" remapped code for mixins that might be broken
  • isShiftDown moved from Screen to Minecraft (aka MinecraftClient in Yarn), I searched and couldn't find that and thought it's just gone for good. So, there are places where isShiftDown is commented out (for shift-clicking on increment/decrement buttons to change the value 10x), and can be fixed trivially

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants