fix: stop mutating JsonPath JVM-global defaults#191
Open
testower wants to merge 1 commit intoMobilityData:masterfrom
Open
fix: stop mutating JsonPath JVM-global defaults#191testower wants to merge 1 commit intoMobilityData:masterfrom
testower wants to merge 1 commit intoMobilityData:masterfrom
Conversation
AbstractVersion's static initializer called Configuration.setDefaults(...) to install JsonOrgJsonProvider as the JVM-wide JsonPath default. Once that class loaded, every other JsonPath user in the same process was forced onto the org.json provider — which only recognises org.json.JSONObject as a map. A consumer using JsonPath against Jackson-parsed maps (e.g. Spring's WebGraphQlTester feeding LinkedHashMap responses to JsonPath) would then fail with PathNotFoundException whenever validator classes happened to load before that consumer first evaluated a path. Class-load order makes the bug intermittent: it surfaces in some test environments but not others. Replace the global mutation with a SchemaJsonPath facade that exposes a single static parse(Object) returning a DocumentContext bound to a private JsonOrg-configured Configuration. All JsonPath.parse(jsonObject) call sites in AbstractVersion and the rule patchers now route through the facade, so adding a new schema-patching rule cannot accidentally fall back to the default provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractVersion's static initializer called Configuration.setDefaults(...) to install JsonOrgJsonProvider as the JVM-wide JsonPath default. Once that class loaded, every other JsonPath user in the same process was forced onto the org.json provider — which only recognises org.json.JSONObject as a map. A consumer using JsonPath against Jackson-parsed maps (e.g. Spring's WebGraphQlTester feeding LinkedHashMap responses to JsonPath) would then fail with PathNotFoundException whenever validator classes happened to load before that consumer first evaluated a path. Class-load order makes the bug intermittent: it surfaces in some test environments but not others.
Replace the global mutation with a SchemaJsonPath facade that exposes a single static parse(Object) returning a DocumentContext bound to a private JsonOrg-configured Configuration. All JsonPath.parse(jsonObject) call sites in AbstractVersion and the rule patchers now route through the facade, so adding a new schema-patching rule cannot accidentally fall back to the default provider.