Add spec for SharedClusterEnvironment.md#5632
Closed
Navdeep-ss wants to merge 1 commit into
Closed
Conversation
API proposal for a shared WebView2 cluster environment using the symmetric Create + synchronous Get model (Approach 2). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Superseded by #5633, which uses the correct review-branch naming convention (base SharedClusterEnvironment, head SharedClusterEnvironment-draft). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an API review for the new Shared WebView2 Cluster Environment API.
It implements Approach 2 (symmetric
Create+ synchronousGet) from the internal design doc, the recommended proposal.What this adds
CreateCoreWebView2ClusterEnvironment(options, handler)- symmetric async entry point every cooperating host calls with its full desired options. First-creator-wins pins the option set for the clusterId.GetCoreWebView2ClusterEnvironmentOptions(id, options)- synchronous read of the pinned options for a clusterId, no browser spawn, for pre-flight.ICoreWebView2ClusterEnvironmentOptions- process-wide options plus the rendezvousId.ICoreWebView2CreateClusterEnvironmentCompletedHandler- returns the shared environment, orERROR_CLUSTER_ENVIRONMENT_OPTIONS_MISMATCH.CoreWebView2Environment.CreateClusterEnvironmentAsync/GetClusterEnvironmentOptionsand theCoreWebView2ClusterEnvironmentOptionsruntimeclass.Notes for reviewers