fix: Increase iframe unload timeout#3971
Merged
FrederikBolding merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3971 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 429 429
Lines 12363 12363
Branches 1942 1942
=======================================
Hits 12185 12185
Misses 178 178 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mrtenz
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase the iframe unload timeout significantly to prevent issues where the timeout would be too low and thus the workaround wouldn't be effective.
When testing this I've seen spikes up to 200ms, but mostly in the 10-50ms range. Though, we've decided to bump to a full second, since we don't expect to hit this often (if at all).
https://consensyssoftware.atlassian.net/browse/WPC-987
Note
Low Risk
Low risk: a single timeout constant is increased to reduce flaky iframe teardown; the main behavioral change is waiting longer before removing the iframe in edge cases.
Overview
Increases the
withTimeoutduration used duringIframeExecutionService.terminateJobteardown (waiting for theabout:blankload) from10ms to1_000ms before removing the iframe, making unload/cleanup more reliable under slower load events.Reviewed by Cursor Bugbot for commit 747ccab. Bugbot is set up for automated code reviews on this repo. Configure here.