feat(evm-wallet-experiment): Use object capability sheaves#947
Draft
grypez wants to merge 5 commits intogrypez/bringing-in-the-sheavesfrom
Draft
feat(evm-wallet-experiment): Use object capability sheaves#947grypez wants to merge 5 commits intogrypez/bringing-in-the-sheavesfrom
grypez wants to merge 5 commits intogrypez/bringing-in-the-sheavesfrom
Conversation
The delegation twin's interface guard uses M.eq(lowercaseToken) to match the token address, so dispatch through the sheaf must pass the token in canonical lowercase form. Callers that supply a mixed-case address were being silently filtered out of the twin stalk and falling through to the home section. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…emantics Once a matched stalk section throws, the sheaf continues dispatch through the remaining sections. The e2e scenario now asserts that an over-budget spend falls through from the delegation twin to the call-home section and that transfer still succeeds via the home coordinator (using a direct EOA tx, so no UserOp polling). Also extend dockerExec with an optional timeoutMs so the two-spend scenario fits within a longer window on bundler-hybrid. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
… subpath The rebase onto grypez/bringing-in-the-sheaves introduced a semantic conflict: d3b397d moved sheaf exports from the main kernel-utils index to the ./sheaf subpath, but the evm-wallet commits still imported from the old path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tead of section.token The old DelegationSection type exposed a .token property that reflected the normalized address. PresheafSection does not — the lowercased token is now embedded in the transferFungible method guard (M.eq(token)) rather than carried on the return value. Use getInterfaceGuardPayload/getMethodGuardPayload from @endo/patterns to extract the first arg guard and verify it accepts the lowercase form but rejects the original checksummed address. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draft
Refs: #870