fix(evm-wallet-experiment): use URL.hostname in integration test allo…#946
Merged
fix(evm-wallet-experiment): use URL.hostname in integration test allo…#946
Conversation
…wedHosts
URL.host includes the port ('127.0.0.1:PORT') but makeHostCaveat checks
URL.hostname which strips the port. Same regression as the docker e2e fix.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Coverage Report
File CoverageNo changed files found. |
sirtimid
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…wedHosts
URL.host includes the port ('127.0.0.1:PORT') but makeHostCaveat checks URL.hostname which strips the port. Same regression as the docker e2e fix in #945
Note
Low Risk
Low risk: a test-only change that corrects hostname/port handling to prevent false allowlist failures.
Overview
Updates the OpenClaw wallet plugin integration test to derive
allowedHostsfromURL.hostnameinstead ofURL.host, avoiding inclusion of the ephemeral RPC server port so host allowlisting matches the production hostname check.Reviewed by Cursor Bugbot for commit 1d133fd. Bugbot is set up for automated code reviews on this repo. Configure here.