Add java-tron-up package#8825
Open
ulissesferreira wants to merge 3 commits into
Open
Conversation
ulissesferreira
temporarily deployed
to
default-branch
GitHub Actions
Inactive
Contributor
Author
|
Code sync follow-up:
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 501f3e3. Configure here.
| } | ||
|
|
||
| process.exit(result.status ?? 0); | ||
| `, |
There was a problem hiding this comment.
Generated wrapper uses CJS in extensionless file
Medium Severity
The installJavaTronBinary function generates an extensionless wrapper script at node_modules/.bin/java-tron that uses CJS-only constructs (require() and __dirname). Node.js determines the module system for extensionless files based on the nearest parent package.json's "type" field. In consuming projects with "type": "module", Node.js v22+ will treat this wrapper as ESM, causing a ReferenceError: require is not defined at runtime. The package's engine range (>=20) includes these affected versions.
Reviewed by Cursor Bugbot for commit 501f3e3. Configure here.
Contributor
Author
|
@metamaskbot publish-preview |
1 similar comment
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
@metamask/java-tron-upto the core monorepo using the generated package structure, then replaces the scaffold with the existing java-tron runtime installer implementation.Ownership follows the runtime tooling/platform pattern and includes Networks, matching the Tron Snap ownership direction.
Changes
packages/java-tron-up.java-tron-upCLI bin fromdist/bin/java-tron-up.mjs.teams.jsonownership.Verification
yarn workspace @metamask/java-tron-up run buildyarn workspace @metamask/java-tron-up run testyarn eslint packages/java-tron-upyarn constraintsyarn lint:misc --check packages/java-tron-up/package.json packages/java-tron-up/README.md packages/java-tron-up/src/index.ts packages/java-tron-up/src/install.ts packages/java-tron-up/src/install.test.ts packages/java-tron-up/src/bin/java-tron-up.ts packages/java-tron-up/jest.config.js .github/CODEOWNERS teams.json README.md tsconfig.json tsconfig.build.jsonyarn readme-content:checkyarn lint:teamsyarn workspace @metamask/java-tron-up run changelog:validateNote
Medium Risk
Introduces a new CLI that downloads and executes pinned external Java/TRON artifacts, which can affect CI/dev environments if URLs/checksums or cache logic are wrong. No existing runtime/auth/business logic is modified beyond adding the package and wiring it into the monorepo.
Overview
Adds a new package,
@metamask/java-tron-up, providing ajava-tron-upCLI to download, checksum-verify, cache, and install ajava-tronwrapper binary (pluscache cleansupport) with configurable artifact URLs via CLI and rootpackage.json.Wires the package into the monorepo (TypeScript project refs,
yarn.lock, root README package list/dependency graph) and sets ownership inCODEOWNERS/teams.json, plus standard package metadata (license, changelog, typedoc, Jest config/tests).Reviewed by Cursor Bugbot for commit 73cf603. Bugbot is set up for automated code reviews on this repo. Configure here.