feat(analytics-controller): add persisted event queue#8797
Open
gauthierpetetin wants to merge 6 commits into
Open
feat(analytics-controller): add persisted event queue#8797gauthierpetetin wants to merge 6 commits into
gauthierpetetin wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c43147b. Configure here.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
Adds optional persisted event queue support to @metamask/analytics-controller.
The feature is disabled by default and can be enabled by clients that do not have SDK-level persistence. When enabled, final analytics payloads are persisted before delivery and removed only after the platform adapter reports successful delivery.
References
NA
Checklist
Note
Medium Risk
Adds optional persistence/replay of analytics delivery payloads and changes adapter method signatures to accept delivery callbacks/options, which could affect client adapters if typings/implementations aren’t updated. Default behavior is unchanged when the feature flag is off.
Overview
Adds an opt-in persisted delivery queue to
AnalyticsController(isEventQueuePersistenceEnabled) that storestrack/identify/viewadapter payloads bymessageIduntil the adapter acknowledges success via a callback, and replays queued payloads oninit(dropping invalid entries and clearing the queue when opted out).Extends
AnalyticsPlatformAdaptermethods to accept optionalAnalyticsDeliveryOptions(messageId,timestamp,callback), addseventQueueto controller state metadata as persisted but excluded from logs/debug snapshots/UI, and updates docs, exports, deps (uuid), and tests to cover the new behavior.Reviewed by Cursor Bugbot for commit 0a79f0e. Bugbot is set up for automated code reviews on this repo. Configure here.