Repository navigation
Varobs cx xios fix - #300
Conversation
Chris Thomas (ctgh)
left a comment
There was a problem hiding this comment.
Thanks for the fix!
|
Jonas Ganderton (@mo-jonasganderton) can you try retriggering the CI please? |
|
Chris Thomas (@ctgh) Just tried a few times, including with debug mode. It always seems to skip the gnu-openmpi check? |
|
A few ordinary malak and sith runs with the build but no further changes. Michael Cooke (@mikecooke77) |
|
Not sure why but I can't merge this PR. I see the message "Cannot update this protected ref." |
|
I tried creating a new branch and PR (#302), but it had the same error message "Cannot update this protected ref.". |
Summary
Enables the Varobs Writer and CX Writer filters to work when XIOS is used in server mode.
Done by switching from using mpl_comm_world to mpi_group in the relevant filters.
Testing
mo-bundle tests
I've tested malak kgo_glu_jopa_jada using XIOS in server mode, this results in KGO changes for JOPA and JADA. This is not the default behaviour, but demonstrates this works should we want to change.
This was done using a couple of custom branches - these are not designed for merging, primarily because I've taken the 4dvar iodef for testing purposes.
Resolves