Skip to content

Varobs cx xios fix - #300

Merged
Matt Shin (matthewrmshin) merged 4 commits into
developfrom
feature/varobs_cx_xios_fix
Oct 13, 2026
Merged

Matt Shin (matthewrmshin) merged 4 commits into
developfrom
feature/varobs_cx_xios_fix

Conversation

@mo-jonasganderton

@mo-jonasganderton Jonas Ganderton (mo-jonasganderton) commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Enables the Varobs Writer and CX Writer filters to work when XIOS is used in server mode.
Done by switching from using mpl_comm_world to mpi_group in the relevant filters.

Testing

mo-bundle tests

I've tested malak kgo_glu_jopa_jada using XIOS in server mode, this results in KGO changes for JOPA and JADA. This is not the default behaviour, but demonstrates this works should we want to change.
This was done using a couple of custom branches - these are not designed for merging, primarily because I've taken the 4dvar iodef for testing purposes.

  • Uses custom jjdocs branch - feature/test_xios
    • New configuration.nml for C48-C192 with XIOS
    • jopa_process adapted to use XIOS server mode
    • XIOS replacing monio in yamls
    • Extra fields to field def
  • Uses custom malak changes to make use of the jjdocs changes

Resolves

@ctgh Chris Thomas (ctgh) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ctgh

Copy link
Copy Markdown
Collaborator

Jonas Ganderton (@mo-jonasganderton) can you try retriggering the CI please?

@mo-jonasganderton
Jonas Ganderton (mo-jonasganderton) marked this pull request as ready for review October 5, 2026 10:45
@mo-jonasganderton

Copy link
Copy Markdown
Contributor Author

Chris Thomas (@ctgh) Just tried a few times, including with debug mode. It always seems to skip the gnu-openmpi check?

@mo-jonasganderton

Copy link
Copy Markdown
Contributor Author

A few ordinary malak and sith runs with the build but no further changes.

Michael Cooke (@mikecooke77)
I tried running all initially but ran into a couple problems, then triggered these manually instead. There is no sith-start-data-2, only 3,4,5 where 3 and 4 had odb dirs and 5 is the default. The above sith uses 4.

@ctgh

Copy link
Copy Markdown
Collaborator

Not sure why but I can't merge this PR. I see the message "Cannot update this protected ref."

@mo-jonasganderton

Copy link
Copy Markdown
Contributor Author

I tried creating a new branch and PR (#302), but it had the same error message "Cannot update this protected ref.".

@matthewrmshin
Matt Shin (matthewrmshin) merged commit b638179 into develop Oct 13, 2026
2 checks passed
@matthewrmshin
Matt Shin (matthewrmshin) deleted the feature/varobs_cx_xios_fix branch October 13, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use a supplied communicator group and not MPI_COMM_WORLD

5 participants