Repository navigation
Remove superlinter dependency and refactor/format the entire codebase - #263
Open
Yaswant Pradhan (yaswant) wants to merge 1 commit into
Open
Yaswant Pradhan (yaswant) wants to merge 1 commit into
Yaswant Pradhan (yaswant) wants to merge 1 commit into
Conversation
Collaborator
|
No, this is way too big and is trivial to split up into multiple PRs. Please do that and then we can get it reviewed more effectively |
Collaborator
Author
|
Hmm... I’m not sure I fully understand what you mean by “way too big” - are you referring to the number of files touched? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Replace superlinter and refactor codebase
Sci/Tech Reviewer: Erica Neininger (@ericaneininger)
Code Reviewer: James Bruten (@james-bruten-mo)
Replace Super-Linter with shared local and CI checks using uv, pre-commit, Ruff, rumdl, ShellCheck, actionlint, zizmor, and gitleaks.
Pin hooks to full commit SHAs and lock Python dependencies, retaining setuptools 80.9.0 for compatibility (just in case).
Add Dependabot updates and document emergency CVE triage and required GitHub alert settings (see README).
Enable editable installs and document development/testing with both uv and pip.
Standardise copyright headers while preserving exact-content fixtures.
Fix the detached-head test’s dependency on local Git log formatting.
Apply ruff lint/format to the entire codebase
closes Replace superlinter with better alternatives #262
Code Quality Checklist
Testing
Security Considerations
AI Assistance and Attribution
Assisted-by: Met Office Copilot Business (GPT-6.1 Sol)
for updating the
README.mdfileSci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review