Skip to content

Remove superlinter dependency and refactor/format the entire codebase - #263

Open
Yaswant Pradhan (yaswant) wants to merge 1 commit into
MetOffice:mainfrom
yaswant:update-actions
Open

Yaswant Pradhan (yaswant) wants to merge 1 commit into
MetOffice:mainfrom
yaswant:update-actions

Conversation

@yaswant

@yaswant Yaswant Pradhan (yaswant) commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

PR Summary

Replace superlinter and refactor codebase

Sci/Tech Reviewer: Erica Neininger (@ericaneininger)
Code Reviewer: James Bruten (@james-bruten-mo)

  • Replace Super-Linter with shared local and CI checks using uv, pre-commit, Ruff, rumdl, ShellCheck, actionlint, zizmor, and gitleaks.

  • Pin hooks to full commit SHAs and lock Python dependencies, retaining setuptools 80.9.0 for compatibility (just in case).

  • Add Dependabot updates and document emergency CVE triage and required GitHub alert settings (see README).

  • Enable editable installs and document development/testing with both uv and pip.

  • Standardise copyright headers while preserving exact-content fixtures.

  • Fix the detached-head test’s dependency on local Git log formatting.

  • Apply ruff lint/format to the entire codebase

  • closes Replace superlinter with better alternatives #262

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • This change has been tested appropriately (please describe)

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Assisted-by: Met Office Copilot Business (GPT-6.1 Sol)
for updating the README.md file

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Security considerations have been addressed
  • Performance impact is acceptable

@james-bruten-mo

Copy link
Copy Markdown
Collaborator

No, this is way too big and is trivial to split up into multiple PRs. Please do that and then we can get it reviewed more effectively

@yaswant Yaswant Pradhan (yaswant) changed the title Remove superlinter dependency and refactor/format to the entire codebase Remove superlinter dependency and refactor/format the entire codebase Nov 9, 2026
@yaswant

Copy link
Copy Markdown
Collaborator Author

Hmm... I’m not sure I fully understand what you mean by “way too big” - are you referring to the number of files touched?
The main changes are in ~/.github/workflow and the pre-commit config. To keep the branch clean, the remaining files have been reformatted without changing the code logic. There are a few files where I can remove the copyright header, but that won’t significantly reduce the number, if that is your main concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace superlinter with better alternatives

2 participants