docs(agent): stops describing the subscription lookup as optional - #12897
Merged
Conversation
Contributor
Merge Protections🟢 All 5 merge protections satisfied — ready to merge. Show 5 satisfied protections🟢 👀 Review Requirements
🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 Reviews
🟢 📕 PR description
🟢 🚦 Auto-queueWhen all merge protections are satisfied, this pull request will be queued automatically. |
JulianMaurin
approved these changes
Sep 21, 2026
Contributor
Merge Queue Status
This pull request spent 3 minutes 12 seconds in the queue, including 2 minutes 37 seconds running CI. Required conditions to merge
|
49 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The architecture overview qualified the Subscription API call as optional, in
prose and again in the diagram, where it was the one dashed and muted edge
among solid ones. It is not optional. An on-premise engine that starts without
a subscription token has no subscription mode to run in and refuses to boot,
and the deployment then reaches Mergify's hosted API to check that token — the
same two calls the requirements page already lists as outbound access that must
be allowed.
The two pages therefore said opposite things about the same dependency, and the
architecture page is the one a reader consults when deciding what egress a
deployment needs. Reading it as optional means planning an air-gapped install
that cannot start. The edge is now drawn like every other required call, and
the paragraph points at the requirements page rather than waving the lookup
away.
Evidence: the engine picks its subscription implementation from the
subscription token at import, with no third branch, and the on-premise one
fetches the subscription over HTTP.