[SS-366] update iceberg-rust dep to v0.10.1 - #38084
Open
ublubu wants to merge 1 commit into
Open
Conversation
| iceberg-catalog-rest = { git = "https://github.com/MaterializeInc/iceberg-rust.git", rev = "dedd9231ee88ee979b648e14792878b40e74c20a" } | ||
| iceberg-storage-opendal = { git = "https://github.com/MaterializeInc/iceberg-rust.git", rev = "dedd9231ee88ee979b648e14792878b40e74c20a" } | ||
| # All changes should go to the `mz_v0.10.x` branch. | ||
| iceberg = { git = "https://github.com/MaterializeInc/iceberg-rust.git", rev = "a51ff2c8dce700a1c158c372f8ce94906b5631b1" } |
Contributor
There was a problem hiding this comment.
i feel like we should change this to a branch name instead of rev number, I'm pretty sure this syntax works as well and is considerably more readable:
Suggested change
| iceberg = { git = "https://github.com/MaterializeInc/iceberg-rust.git", rev = "a51ff2c8dce700a1c158c372f8ce94906b5631b1" } | |
| iceberg = { git = "https://github.com/MaterializeInc/iceberg-rust.git", branch = "mz_v0.10.x" } |
Contributor
There was a problem hiding this comment.
I'm now realizing that this does slightly change the way we would need to update the branch - ie we'd need to be quite careful about what gets pulled into the mz_v0.10.x branch as that would then affect MZ in prod, but it's probably a good thing to do some facsimile of a release process for our iceberg fork
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've rebased our
iceberg-rustfork's changes onto upstream'sv0.10.1:https://github.com/MaterializeInc/iceberg-rust/compare/04ae06bdb15a6fd7c7927d29d4e0f6a33de0f1f9..a51ff2c8dce700a1c158c372f8ce94906b5631b1
iceberg-rust$ make testpasses.(For comparison: our changes prior to the rebase)
cc @DAlperin: The rebase included this change to
row_delta.rs::RowDeltaOperation::existing_manifest.previously:
This PR upgrades
arrowandparquetfrom v57 to v58.reqsignalso has a small API change, which means some changes to theAwsSdkCredentialLoaderused for Iceberg FileIO.